Repository navigation
Chore: Remove the authbridge/install.sh stub - #1827
Conversation
authbridge/install.sh was the last file in authbridge/. It ran scripts/install.sh for the URL that v0.7.0 and the 0.7 and 0.8 site docs give. rossoctl/.github#226 changes those docs to the rossoctl.dev URL. Now no current page gives the old URL. The --ref fallback in scripts/install.sh stays. It reads <tag>/authbridge/install.sh, and old tags keep their copy of the file. Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Hai Huang <huang195@gmail.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
clawgenti
left a comment
There was a problem hiding this comment.
Summary
Clean removal of the 13-line authbridge/install.sh stub, the four tests that covered it, and the CLAUDE.md sentence about it. Nothing left on head references the deleted file except the intended --ref=<old tag> legacy probe in scripts/install.sh (L576) and its test arm in scripts/install_test.sh (L411); every existing tag through v0.9.5 still has authbridge/install.sh, so that fallback keeps working. scripts/install_test.sh passes locally on head (272 passed, 0 failed).
I checked the claims in "What does not change": since v0.9.0 the README, release notes (release-binaries.yaml) and agentop update (installerURL) all use https://www.rossoctl.dev/cortex/install.sh, which rossoctl/.github scripts/sync-docs.sh copies from this repo's scripts/install.sh, so it does not depend on the stub. v0.8.x README and release notes already pointed at main/scripts/install.sh. The only in-org users of the old URL are the three versioned site pages that rossoctl/.github#226 rewrites.
Merge order: rossoctl/.github#226 is still open and has no review (REVIEW_REQUIRED). Please merge it first, as the PR body says; otherwise the 0.7/0.8 docs give a URL that returns 404 as soon as this lands on main.
The known cost (a v0.7.0 installer that re-execs <newest tag>/authbridge/install.sh starts getting 404 from the next release) is stated plainly. The asset download counts make it a reasonable trade.
Author: huang195 (MEMBER — maintainer)
Areas reviewed: Shell, Docs
Agent/IDE config (.claude/.vscode): none
Commits: 1 commit, all signed-off: yes
CI status: passing
Problem
authbridge/install.shis the last file inauthbridge/. It is a 13-line stub that runsscripts/install.shfrom the same ref. It exists for the URL that v0.7.0 and the 0.7 and 0.8 site docs give:Depends on rossoctl/.github#226. That PR changes the three site pages to
https://www.rossoctl.dev/cortex/install.sh. Merge it first, or the site gives a URL that returns 404.Change
authbridge/install.sh, and with it theauthbridge/directory.scripts/install_test.sh.What does not change
rossoctl.dev/cortex/install.sh,agentop update, setup's one-liner, the README and the release notes do not use this path.scripts/install.sh --ref=<old tag>still falls back to<tag>/authbridge/install.sh. Old tags keep their copy, so that fallback and its test stay.Known cost
<newest tag>/authbridge/install.sh. From the next release on, that URL returns 404. v0.7.0 shipped on 2026-09-24, seven stable releases replaced it, and itsabctlassets have 27 downloads.Test
sh scripts/install_test.sh: 272 passed, 0 failed.shellcheck --severity=error scripts/install_test.sh: clean.pre-commit runon the changed files: passed.Assisted-By: Claude (Anthropic AI) noreply@anthropic.com