Skip to content

Chore: Remove the authbridge/install.sh stub - #1827

Merged
huang195 merged 1 commit into
rossoctl:mainfrom
huang195:chore/remove-authbridge-dir
Nov 12, 2026
Merged

huang195 merged 1 commit into
rossoctl:mainfrom
huang195:chore/remove-authbridge-dir

Conversation

@huang195

Copy link
Copy Markdown
Member

Problem

authbridge/install.sh is the last file in authbridge/. It is a 13-line stub that runs scripts/install.sh from the same ref. It exists for the URL that v0.7.0 and the 0.7 and 0.8 site docs give:

https://raw.githubusercontent.com/rossoctl/cortex/main/authbridge/install.sh

Depends on rossoctl/.github#226. That PR changes the three site pages to https://www.rossoctl.dev/cortex/install.sh. Merge it first, or the site gives a URL that returns 404.

Change

  • Delete authbridge/install.sh, and with it the authbridge/ directory.
  • Delete the four tests of the stub in scripts/install_test.sh.
  • Delete the stub sentence in the CLAUDE.md "Layout" section.

What does not change

  • rossoctl.dev/cortex/install.sh, agentop update, setup's one-liner, the README and the release notes do not use this path.
  • scripts/install.sh --ref=<old tag> still falls back to <tag>/authbridge/install.sh. Old tags keep their copy, so that fallback and its test stay.

Known cost

  • A v0.7.0 installer that upgrades runs <newest tag>/authbridge/install.sh. From the next release on, that URL returns 404. v0.7.0 shipped on 2026-09-24, seven stable releases replaced it, and its abctl assets have 27 downloads.
  • Copies of the old URL outside the rossoctl org return 404.

Test

  • sh scripts/install_test.sh: 272 passed, 0 failed.
  • shellcheck --severity=error scripts/install_test.sh: clean.
  • pre-commit run on the changed files: passed.

Assisted-By: Claude (Anthropic AI) noreply@anthropic.com

authbridge/install.sh was the last file in authbridge/. It ran
scripts/install.sh for the URL that v0.7.0 and the 0.7 and 0.8 site docs
give. rossoctl/.github#226 changes those docs to the rossoctl.dev URL.
Now no current page gives the old URL.

The --ref fallback in scripts/install.sh stays. It reads
<tag>/authbridge/install.sh, and old tags keep their copy of the file.

Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com>
Signed-off-by: Hai Huang <huang195@gmail.com>
@huang195
huang195 requested a review from a team as a code owner November 12, 2026 14:06
@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d027e168-41b4-4b6b-a07e-8ba6a2d31395
Commits

Reviewing files that changed from the base of the PR and between 14b5bf7 and 60ed289.

Files selected for processing: 3

  • CLAUDE.md
  • authbridge/install.sh
  • scripts/install_test.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@clawgenti clawgenti left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Clean removal of the 13-line authbridge/install.sh stub, the four tests that covered it, and the CLAUDE.md sentence about it. Nothing left on head references the deleted file except the intended --ref=<old tag> legacy probe in scripts/install.sh (L576) and its test arm in scripts/install_test.sh (L411); every existing tag through v0.9.5 still has authbridge/install.sh, so that fallback keeps working. scripts/install_test.sh passes locally on head (272 passed, 0 failed).

I checked the claims in "What does not change": since v0.9.0 the README, release notes (release-binaries.yaml) and agentop update (installerURL) all use https://www.rossoctl.dev/cortex/install.sh, which rossoctl/.github scripts/sync-docs.sh copies from this repo's scripts/install.sh, so it does not depend on the stub. v0.8.x README and release notes already pointed at main/scripts/install.sh. The only in-org users of the old URL are the three versioned site pages that rossoctl/.github#226 rewrites.

Merge order: rossoctl/.github#226 is still open and has no review (REVIEW_REQUIRED). Please merge it first, as the PR body says; otherwise the 0.7/0.8 docs give a URL that returns 404 as soon as this lands on main.

The known cost (a v0.7.0 installer that re-execs <newest tag>/authbridge/install.sh starts getting 404 from the next release) is stated plainly. The asset download counts make it a reasonable trade.

Author: huang195 (MEMBER — maintainer)
Areas reviewed: Shell, Docs
Agent/IDE config (.claude/.vscode): none
Commits: 1 commit, all signed-off: yes
CI status: passing

@huang195
huang195 merged commit e403bd9 into rossoctl:main Nov 12, 2026
38 checks passed
@huang195
huang195 deleted the chore/remove-authbridge-dir branch November 12, 2026 16:48
@github-project-automation github-project-automation Bot moved this from New/ToDo to Done in Rossoctl Issue Prioritization Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants