Skip to content

feat(json): add Rollup 5 compatibility #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TrickyPi wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(json): add Rollup 5 compatibility #2017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aabcb54
feat: add Rollup 5 compatibility
TrickyPi Jul 26, 2026
448749c
Merge branch 'master' into feat/rollup-5/json
shellscape Oct 21, 2026
0f2fd7f
fix(json): use rawId for the extension check and filters
TrickyPi Oct 28, 2026
a3b1e60
Merge branch 'master' into feat/rollup-5/json
TrickyPi Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/json/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@ export default function json(options = {}) {
name: 'json',

// eslint-disable-next-line no-shadow
transform(code, id) {
if (id.slice(-5) !== '.json' || !filter(id)) return null;
transform(code, id, transformOptions) {
const rawId = (transformOptions && transformOptions.rawId) || id;
if (rawId.slice(-5) !== '.json' || !filter(rawId)) return null;

try {
const parsed = JSON.parse(code);
Expand Down
22 changes: 22 additions & 0 deletions packages/json/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,3 +162,25 @@ test('handles empty keys', async () => {
'export var b = "c";\nexport default {\n\t"": "a",\n\tb: b\n};\n'
);
});
test('handles transform options without rawId as passed by Rollup 4', async () => {
expect(json().transform(`{"a":"b"}`, 'input.json', { attributes: {} }).code).toEqual(
'export var a = "b";\nexport default {\n\ta: a\n};\n'
);
});
const idWithJsonAttributes = `input.json?attributes=${encodeURIComponent(
JSON.stringify({ type: 'json' })
)}`;
test('includes json files with import attributes', async () => {
expect(
json({ include: /\.json$/ }).transform(`{"a":"b"}`, idWithJsonAttributes, {
rawId: 'input.json'
}).code
).toEqual('export var a = "b";\nexport default {\n\ta: a\n};\n');
});
test('excludes json files with import attributes', async () => {
expect(
json({ exclude: /\.json$/ }).transform(`{"a":"b"}`, idWithJsonAttributes, {
rawId: 'input.json'
})
).toBeNull();
});
Comment on lines +180 to +186

@lukastaegert lukastaegert Nov 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test currently does not trigger out fix because it filters out the file. What about this

Suggested change
test('excludes json files with import attributes', async () => {
expect(
json({ exclude: /\.json$/ }).transform(`{"a":"b"}`, idWithJsonAttributes, {
rawId: 'input.json'
})
).toBeNull();
});
test('applies exclude patterns to the raw id instead of the encoded id', async () => {
expect(
json({ exclude: /attributes/ }).transform(`{"a":"b"}`, idWithJsonAttributes, {
rawId: 'input.json'
}).code
).toEqual('export var a = "b";\nexport default {\n\ta: a\n};\n');
});

Loading