Skip to content

Release flow: main only, tagged releases, pkgdown deployment - #27

Merged
hypebright merged 5 commits into
mainfrom
21-release-strategy
Nov 9, 2026
Merged

hypebright merged 5 commits into
mainfrom
21-release-strategy

Conversation

@hypebright

Copy link
Copy Markdown
Contributor

Closes #21. Part of rivm-syso/ROvis#23, which has the review order and merge steps.

📘 What is this PR about?

Same change as rivm-syso/ROvis.utils#18: review that one first. release.yaml, ci.yaml and the "Releases" section in CONTRIBUTING.md are identical to it.

Only in this repo:

  • Remotes: → rivm-syso/ROvis.utils@*release.

✅ Checklist

  • I have read contributing guidelines at CONTRIBUTING.md
  • My code follows the style guidelines of this project
  • I have tested these changes and added tests (if applicable)
  • I have added necessary documentation / comments
  • I have linked relevant issues

🧪 How to test / verify

Same as rivm-syso/ROvis.utils#18, after the merge.

ℹ️ Extra info

Same change as rivm-syso/ROvis.utils#18: release.yaml, pkgdown job
re-enabled, pkgdown development mode, URL/BugReports, usethis NEWS
heading, install instructions and a Releases section in CONTRIBUTING.md.
Remotes entries point at the latest release (@*release).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment thread .github/workflows/ci.yaml Fixed
Comment thread .github/workflows/ci.yaml Fixed
Comment thread .github/workflows/ci.yaml Fixed
Pins the third-party actions in ci.yaml to the commits their current tags
point to (CodeQL actions/unpinned-tag). Dependabot keeps them up to date
with one grouped PR per month.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hypebright and others added 2 commits November 9, 2026 14:05
Pin third-party GitHub Actions to commit SHAs, add Dependabot
Four files were not formatted, so the air-format CI job failed. Whitespace and line breaks only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hypebright

Copy link
Copy Markdown
Contributor Author

@tkranenburgrivm FYI: I added one commit that only formats 4 files in R/ with air (whitespace and line breaks, no code changes). CI now runs on PRs into main, and the air-format job flagged these files from earlier commits on develop.

@hypebright hypebright closed this Nov 9, 2026
@hypebright hypebright reopened this Nov 9, 2026
CI now runs on PRs into main and lintr flagged these:
- vignette: indentation of ro_ply_standard() calls, trailing comma
- long @PARAM lines and a long JS selector line (> 120 characters)
- htmlwidgets::onRender() while onRender is already imported

Layout only, no behaviour changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hypebright

Copy link
Copy Markdown
Contributor Author

@tkranenburgrivm FYI: one more commit that fixes the lintr findings CI now reports (from earlier commits on develop): indentation of the ro_ply_standard() calls in the plotly-figures-standard vignette, a trailing comma, two long @param lines, a long JS selector line, and htmlwidgets::onRender() → onRender() (already imported). Layout only, no behaviour changes.

@hypebright
hypebright merged commit 8c642ac into main Nov 9, 2026
8 checks passed
@hypebright
hypebright deleted the 21-release-strategy branch November 9, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploy pkgdown website

3 participants