Repository navigation
Report IoPollDriver as supported on the Io\Poll polyfill - #146
Merged
Merged
Conversation
isSupported() now reports whether the driver can run, which includes symfony/polyfill-io-poll below PHP 8.6, also on Windows, where the polyfill is backed by stream_select() instead of WSAPoll. DriverFactory still only picks the driver automatically on PHP 8.6+, as the polyfill is slower than StreamSelectDriver. The tests now skip based on isSupported(), and a Windows job with the polyfill verifies it works there. The README mentions the driver. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Winsock reports a failed non-blocking connect() only in select()'s except set, which the polyfill does not pass to stream_select(), so writable callbacks on such sockets never run. Treat Windows as unsupported for the polyfill too, like for native WSAPoll, and disable the Windows polyfill CI job until the polyfill handles this. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
trowski
approved these changes
Nov 14, 2026
nicolas-grekas
added a commit
to symfony/polyfill
that referenced
this pull request
Nov 15, 2026
…nicolas-grekas) This PR was merged into the 1.x branch. Discussion ---------- [Io/Poll] Report failed async connects on Windows Winsock reports a failed non-blocking connect() only in select()'s exceptfds, never in writefds, so a watcher waiting for Event::Write on such a socket was never woken up. On Windows, also select the write-watched streams for exceptions and report a stream flagged there without a peer as Write|Error|HangUp, like poll() does. Please verify the behavior is correct on Windows using the Revolt test suite: revoltphp/event-loop#146 Commits ------- 95cc758 [Io/Poll] Report failed connects for all watchers and fix 32-bit timeouts 9f55250 [Io/Poll] Report failed async connects on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isSupported() now reports whether the driver can run, which includes symfony/polyfill-io-poll below PHP 8.6, also on Windows, where the polyfill is backed by stream_select() instead of WSAPoll. DriverFactory still only picks the driver automatically on PHP 8.6+, as the polyfill is slower than StreamSelectDriver.
The tests now skip based on isSupported(), and a Windows job with the polyfill verifies it works there. The README mentions the driver.