Repository navigation
Fix pending MCP session shutdown and add ShellCheck CI - #317
Open
ChrisEvans2 wants to merge 2 commits into
Open
ChrisEvans2 wants to merge 2 commits into
ChrisEvans2 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancel the MCP session holder when connection setup fails or is cancelled. A holder blocked while entering
client.session()cannot observe the stop event, which could leave shutdown waiting indefinitely.Add regression coverage for shutdown during session entry/tool loading, connection timeouts, tool-loading errors, AnyIO cleanup, and successful reconnection after failure. Also run
shellcheck scripts/*.shin CI to match the existing local lint check.Validation:
make lintmake test: 866 backend and 442 frontend tests passed; 30 opt-in tests deselecteduv run --project backend pytest scripts -q: 31 passedmake build