Skip to content

Fix pending MCP session shutdown and add ShellCheck CI - #317

Open
ChrisEvans2 wants to merge 2 commits into
regnull:mainfrom
ChrisEvans2:fix/shellcheck-ci-mcp-shutdown
Open

ChrisEvans2 wants to merge 2 commits into
regnull:mainfrom
ChrisEvans2:fix/shellcheck-ci-mcp-shutdown

Conversation

@ChrisEvans2

Copy link
Copy Markdown

Cancel the MCP session holder when connection setup fails or is cancelled. A holder blocked while entering client.session() cannot observe the stop event, which could leave shutdown waiting indefinitely.

Add regression coverage for shutdown during session entry/tool loading, connection timeouts, tool-loading errors, AnyIO cleanup, and successful reconnection after failure. Also run shellcheck scripts/*.sh in CI to match the existing local lint check.

Validation:

  • make lint
  • make test: 866 backend and 442 frontend tests passed; 30 opt-in tests deselected
  • uv run --project backend pytest scripts -q: 31 passed
  • make build
  • Fork CI: backend, frontend, and ShellCheck passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant