[alies-dev]

AssertRegExpRector crashes with ShouldNotHappenException when the expected value of assertSame()/assertEquals() is not an int literal or a constant, for example in a data-provider test:

$this->assertSame($expectMatch ? 1 : 0, preg_match('/.../', $string));

System error: "Look at "Rector\PHPUnit\PHPUnit90\Rector\MethodCall\AssertRegExpRector::resolveOldCondition()"

The rule now skips these calls. It also skips int literals other than 0 and 1: assertSame(2, preg_match(...)) matched neither rename branch, so the rule moved the preg_match() arguments up and left an assertSame() with the regex as its expected value.

[samsonasik]

Thank you @alies-dev