Skip to content

refactor: Unify CLI request and error handling - #33

Open
sidneyswift wants to merge 1 commit into
mainfrom
codex/untangle-transport-2026-11-09
Open

sidneyswift wants to merge 1 commit into
mainfrom
codex/untangle-transport-2026-11-09

Conversation

@sidneyswift

@sidneyswift sidneyswift commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Use one private request transport beneath existing GET/POST interfaces; preserve query, headers, bodies and HTTP/application error behavior.

Verification

94 tests in 14 files and production build pass. Independent reviewer repeated 17 client tests and found no actionable issues.

Scope and review

Part of the user-requested Recoup monorepo untangle-codebase workflow. Audit and decision log preceded implementation. Changes stay in this owning repository; no production deployment or main-branch merge requested. No broad comment/test-pruning sweep. Existing local work and retired checkouts preserved.

Each repository PR is independently reviewable; the Mono report will collect the coordinated audit, retained cases and check limitations.


Summary by cubic

Unifies get and post behind a single private request helper so query building, headers, body handling, and error policy live in one place. No behavior change for callers: GET and POST responses keep the existing error precedence (data.error, then data.message, then Request failed: <status>), and malformed JSON now propagates without retrying.

  • Adds tests covering GET and POST response contracts, including application-level errors and invalid JSON responses.

Written for commit 6b5f458. Summary will update on new commits.

View guided diff Turn on auto-fix

@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 87c4399f-b4ae-48d0-a64f-4d5925da9096
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

View guided diff | Turn on auto-fix | Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant