Skip to content

Revert grouped GPU decoding (api#1234) - #1241

Merged
sswiftdrtv merged 1 commit into
mainfrom
codex/revert-flamingo-parallel
Nov 10, 2026
Merged

sswiftdrtv merged 1 commit into
mainfrom
codex/revert-flamingo-parallel

Conversation

@sswiftdrtv

Copy link
Copy Markdown
Contributor

Why

#1234 decoded a batch's prompts together on the GPU to make full_report faster. It was merged without a GPU run, with a stated fallback: verify on production and revert if it didn't help. In production it doubled the time and the billed seconds.

Same song: a public-domain 1915 Edison recording, 3:59. Each run followed a fresh Modal deploy.

full_report after #1233 (one at a time) after #1234 (grouped)
Wall time 181 s 367 s
Billed seconds 179 365
Seconds charge (approx.) $0.21 $0.43

Moment descriptions barely moved (80 s → 75 s). The greedy presets' answers drifted by a few tokens, as #1234 expected, so the problem is speed and cost, not answer quality.

Callers can't fall back to one-at-a-time decoding: group_size is a Modal field the API doesn't send. So the revert is the only fallback.

What changes

This reverts the merge commit 026071c. generate_batch goes back to answering prompts one at a time: the code verified in production after #1233. Only modal/ changes, and its three files match main before #1234.

Follow-up

Find out where the time goes before trying grouped decoding again. Candidates:

  • OOM split-and-retry on a long song, where failed attempts still count toward elapsed time.
  • A whole group waiting on its longest answer (lyrics).

#1234's bench entrypoint can measure this, but needs access to the shared Modal workspace.

🤖 Generated with Claude Code

In production, grouped decoding doubled full_report instead of cutting it:
on the same song, wall time went from 181 s to 367 s and billed seconds
from 179 to 365. generate_batch goes back to answering prompts one at a
time, as verified after api#1233.

This reverts merge commit 026071c.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api Ready Ready Preview Nov 10, 2026 1:25am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 3

  • modal/README.md is excluded by none and included by none
  • modal/serve_music_flamingo.py is excluded by none and included by none
  • modal/test_serve_music_flamingo.py is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T01:26:30.221508Z ba8b808 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sswiftdrtv
sswiftdrtv merged commit f7188f4 into main Nov 10, 2026
7 checks passed

This branch was successfully deployed

1 active deployment
Preview — ba8b8083 Deployed Nov 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants