Repository navigation
Make generated docs reproducible - #856
Merged
Merged
Conversation
* Fix home directory, user name, pid, `pb_timestamp`, and the `pb_id` counter in asciicast examples so `.Rd` output doesn't depend on who renders it or when. * `devtools::document()` now reuses existing animated SVGs instead of re-recording them; run `tools/render-svgs.R` to regenerate.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this is the right approach or not, but feels like we need someway to opt-in of rebuilding the SVGs.
🤖 Written by AI 🤖
Reduces churn in
man/when runningdevtools::document(). The asciicast examples now use a fixed home directory, user, pid, timestamp and progress bar id. Animated SVGs (which embed real recording timings) are no longer re-recorded bydocument(); useRscript tools/render-svgs.Rto regenerate them.