Repository navigation
Fix visual editor response to quickSuggestion setting for new default - #1216
Merged
Merged
Conversation
Member
Author
|
@juliasilge please take a very brief glance at this. I would almost just merge it but am curious if any thoughts occur to you about settings stuff like this. |
juliasilge
approved these changes
Nov 4, 2026
juliasilge
left a comment
juliasilge
left a comment
Collaborator
There was a problem hiding this comment.
I think this looks good! Can we make the changelog entry more clear, though?
Co-authored-by: Julia Silge <julia.silge@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VSCode changed its default setting for
editor.quickSuggestionstooffWhenInlineCompletionsand the Visual Editor was not checking the value correctly, causing snippets to not show up in the visual editor when they should.This PR makes the VisualEditor consider more values of
editor.quickSuggestionsto be enabled, includingeditor.quickSuggestions.