Repository navigation
feat(spark): push list predicates into V2 native scans - #117
Open
ChristopherWirt wants to merge 3 commits into
Open
ChristopherWirt wants to merge 3 commits into
ChristopherWirt wants to merge 3 commits into
Conversation
Signed-off-by: Christopher Wirt <cwirt@quantcast.com>
- Emit nested field paths from list predicates instead of special-casing whole structs in the shared ReadTypes.filterable, which had stopped `s.a` filters being pushed alongside Spark's inferred `isnotnull(s)`. - Share the comparable-type rule between V1 literals and list filters, without allocating native expressions to check a type. - Resolve filterable columns once per file and AND all converted filters in one native call. - Rename the plumbing to nativePredicates and tidy tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…redicate-pushdown # Conflicts: # java/vortex-spark/common/src/main/java/dev/vortex/spark/read/VortexPartitionReader.java # java/vortex-spark/common/src/main/java/dev/vortex/spark/read/VortexPartitionReaderFactory.java
ChristopherWirt
marked this pull request as ready for review
November 12, 2026 08:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #116.
Problem
Filters cannot express list predicates such asarray_contains(tags, 'x')orexists(items, x -> x.price > 100).Change
VortexScanturns supported CatalystArrayContains/ArrayExistsdata filters intoVortexListFilters, which compile to nativelistContains/listTransform. Supported inside the predicate: comparisons,AND/OR/NOT, null checks, and struct fields of the element.VortexListFilterholds the Catalyst predicate, not native handles. It travels to executors through a small JavaNativePredicateinterface, because the Java sources compile before the Scala ones.Not in scope
VortexFileFormat) pushdown and list-element zone pruning.array<struct>, any unsupported or missing sibling field in the element struct (amap, or a ms timestamp, for example) disables pushdown for that file. This is conservative, not wrong. RecursingReadTypes.filterableinto arrays would fix it.Testing
spotlessCheckis clean.ReadTypesTestandVortexListFilterTestcases, and the existing V1VortexFilterPushdownTestcases.NativeExpression.variable. On currentdevelopthe Rust code compiles, but a local build hasn't completed yet. Draft until those cases pass.🤖 Generated with Claude Code