Skip to content

Bump setuptools to 84.2.* #16692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Avasam merged 2 commits into from
Nov 3, 2026
Merged

Bump setuptools to 84.2.* #16692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6763452
Bump setuptools to 84.2.*
Avasam Nov 3, 2026
8cec0bb
Restore stubtest allowlist
Avasam Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stubs/setuptools/METADATA.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version = "84.0.*"
version = "84.2.*"
upstream-repository = "https://github.com/pypa/setuptools"
extra-description = """\
Given that `pkg_resources` is typed since `setuptools >= 71.1`, \
Expand Down
10 changes: 6 additions & 4 deletions stubs/setuptools/setuptools/archive_util.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,18 @@ from collections.abc import Callable
from ._distutils.errors import DistutilsError

__all__ = [
"unpack_archive",
"unpack_zipfile",
"unpack_tarfile",
"default_filter",
"UnrecognizedFormat",
"UnsafeMember",
"default_filter",
"extraction_drivers",
"unpack_archive",
"unpack_directory",
"unpack_tarfile",
"unpack_zipfile",
]

class UnrecognizedFormat(DistutilsError): ...
class UnsafeMember(DistutilsError): ...

def default_filter(src, dst): ...
def unpack_archive(filename, extract_dir, progress_filter=..., drivers=None) -> None: ...
Expand Down
3 changes: 3 additions & 0 deletions stubs/setuptools/setuptools/command/bdist_wheel.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ def get_platform(archive_root: str | None) -> str: ...
def get_flag(var: str, fallback: bool, expected: bool = True, warn: bool = True) -> bool: ...
def get_abi_tag() -> str | None: ...
def safer_version(version: str) -> str: ...
def stable_abi_tag(impl_name: str, impl_version: str) -> Literal["abi3", "abi3.abi3t"] | None: ...

@Avasam Avasam Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subjectively decided to make return type literal here. Given the few choices from standard.

Could instead do:

Suggested change
def stable_abi_tag(impl_name: str, impl_version: str) -> Literal["abi3", "abi3.abi3t"] | None: ...
def stable_abi_tag(impl_name: str, impl_version: str) -> str | None: ...

Also impl_version is intended to receive "315", although it could work with ("3", "15"). But I've never seen tuple version use anything else than actual int, so seems pretty unintended.


class bdist_wheel(Command):
description: ClassVar[str]
Expand Down Expand Up @@ -46,6 +47,8 @@ class bdist_wheel(Command):
def finalize_options(self) -> None: ...
@property
def wheel_dist_name(self) -> str: ...
@property
def abi_tag(self) -> str: ...
def get_tag(self) -> tuple[str, str, str]: ...
def run(self) -> None: ...
def write_wheelfile(self, wheelfile_base: str, generator: str = ...) -> None: ...
Expand Down
2 changes: 1 addition & 1 deletion stubs/setuptools/setuptools/command/build_ext.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ have_rtld: bool
use_stubs: bool
libtype: str

def get_abi3_suffix(): ...
def get_abi3_suffix() -> str | None: ...

class build_ext(_build_ext):
distribution: Distribution # override distutils.dist.Distribution with setuptools.dist.Distribution
Expand Down
Loading