Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Doc/library/datetime.rst
Original file line number Diff line number Diff line change
Expand Up @@ -950,6 +950,11 @@ Constructor:
.. versionchanged:: 3.6
Added the *fold* parameter.

.. versionchanged:: 3.16
Comment thread
m-aciek marked this conversation as resolved.
Resolved
:class:`!datetime` now supports the subscript (``[]``) operator for creating
:class:`generic aliases <types.GenericAlias>`, e.g., ``datetime[tzinfo]``.
See :pep:`585` and :ref:`types-genericalias`.


Other constructors, all class methods:

Expand Down
3 changes: 3 additions & 0 deletions Lib/_pydatetime.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import time as _time
import math as _math
import sys
import types as _types
from operator import index as _index

def _cmp(x, y):
Expand Down Expand Up @@ -2432,6 +2433,8 @@ def __reduce_ex__(self, protocol):
def __reduce__(self):
return self.__reduce_ex__(2)

__class_getitem__ = classmethod(_types.GenericAlias)


datetime.min = datetime(1, 1, 1)
datetime.max = datetime(9999, 12, 31, 23, 59, 59, 999999)
Expand Down
17 changes: 17 additions & 0 deletions Lib/test/datetimetester.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,23 @@ def test_divide_and_round(self):
self.assertEqual(dar(6, -4), -2)
self.assertEqual(dar(-6, -4), 2)

def test_datetime_class_getitem(self):
"""Test that datetime class supports subscripting via __class_getitem__."""
from types import GenericAlias
datetime = datetime_module

# Test datetime class can be subscripted
alias = datetime.datetime[tzinfo]
self.assertIsInstance(alias, GenericAlias)
self.assertIs(alias.__origin__, datetime.datetime)
self.assertEqual(alias.__args__, (tzinfo,))

# Test multiple type arguments
alias_multi = datetime.datetime[tzinfo, str]
self.assertIsInstance(alias_multi, GenericAlias)
self.assertIs(alias_multi.__origin__, datetime.datetime)
self.assertEqual(alias_multi.__args__, (tzinfo, str))


#############################################################################
# tzinfo tests
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Allow :class:`datetime.datetime` to accept type parameters at runtime, for
example ``datetime[tzinfo]``.
3 changes: 3 additions & 0 deletions Modules/_datetimemodule.c
Original file line number Diff line number Diff line change
Expand Up @@ -7305,6 +7305,9 @@ static PyMethodDef datetime_methods[] = {
DATETIME_DATETIME___REDUCE_EX___METHODDEF
DATETIME_DATETIME___REDUCE___METHODDEF

{"__class_getitem__", Py_GenericAlias, METH_O|METH_CLASS,
PyDoc_STR("See PEP 585")},

{NULL, NULL}
};

Expand Down
Loading