Repository navigation
Conversation
GeoJson(filename) opened the file in text mode without an encoding, so it was decoded with the locale encoding. On Windows that garbles or fails on non-ASCII properties (the bundled kuntarajat.geojson raises UnicodeDecodeError under cp932). Read the file as bytes and let json detect the encoding, which also accepts a UTF-8 BOM. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeoJson("file.geojson")opens the file in text mode without an encoding, so it gets decoded with the locale encoding. GeoJSON is UTF-8 (RFC 7946), so on Windows any non-ASCII property is either garbled or raises. The repo's owntests/kuntarajat.geojsondoesn't load under a Japanese locale:With cp1252 (e.g. the Windows CI runners) the Finnish names load as mojibake instead, which may be what #1483 ran into.
The file is now read as bytes and handed to
json.load, which detects the encoding itself. A UTF-8 BOM (some Windows tools write one) also stops breaking the load; before, that raisedJSONDecodeError: Unexpected UTF-8 BOMon every platform.The new test loads a file with non-ASCII properties, with and without a BOM. Without the fix the BOM case fails everywhere and the plain UTF-8 case fails on Windows.