Repository navigation
Accept 19-digit Visa card numbers - #558
Open
Sarbajit-Sengupta wants to merge 1 commit into
Open
Sarbajit-Sengupta wants to merge 1 commit into
Sarbajit-Sengupta wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #556.
visa()rejects a checksum-correct 19-digit Visa-format number solely because it requires 16 digits. Accept 19 digits alongside 16 while retaining the existing prefix and Luhn checks. Visa's Transaction Acceptance Device Guide, section 2.1 describes support for PANs up to 19 digits.Add a synthetic 19-digit example to the shared Visa fixtures, so generic validation and every other card-brand validator exercise it too. Negative cases cover checksum-correct unsupported lengths and incorrect 19-digit checksums.
Validation on Windows / Python 3.13.5: the new positive case fails on the original code;
tox -e lint,type,format,sast,py313passes, including 1,589 tests. Other Python versions were not run locally.