Repository navigation
Conversation
Author
|
Fixed the Python 3.9 CI failures in 1c42d44 by adding Verified on macOS / CPython 3.9.6: the focused suite reproduces 2 failures before the fix and passes all 16 tests after it. The full suite now passes with 1,238 passed and 2 skipped. Ruff lint/format and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Custom encoder dispatch currently sends both context keywords whenever an encoder declares
_parent. An encoder that only accepts_parenttherefore receives an unexpected_sort_keysargument; an encoder that only accepts_sort_keyssilently misses its context.Pass each context value only when the callback accepts that keyword or has
**kwargs. Avoid binding the primary value argument twice when its name is_parentor_sort_keys. Legacy one-argument callbacks, positional-only arguments, callable objects, and partial functions keep their existing calling conventions. Errors raised inside an encoder are propagated without retrying it.Validation on Windows / CPython 3.12.10:
git diff --checkpass.Duplicate Check
Agent Drafting Metadata