Repository navigation
Add wind-dependent freestanding PVsyst temperature preset - #2938
sahaja9707 wants to merge 1 commit into
Conversation
Hey @sahaja9707! 🎉Thanks for opening your first pull request! We appreciate your If AI is used for any portion of this PR, you must vet the content Finally, be sure the PR description includes the PR |
|
I've made a change to add the The PR also documents the wind measurement height and adds a numerical test. All 34 temperature tests and style checks pass. This addresses the free-standing portion of #2834. Could you please review the PR and merge it if everything looks good? I’m happy to address any feedback. |
|
@sahaja9707 you're ahead of the maintainers with this one :) We need to get consensus that pvlib should change these defaults, before reviewing this PR. Thanks for your patience. |
|
I support this improvement. |
The named PVsyst temperature presets currently all have
u_v=0, so selecting them does not account for wind speed. Addfreestanding_windwithu_c=25.0andu_v=1.2, the PVUSA correlation described in PVsyst's heat transfer documentation.Document the wind measurement height and the need to match coefficients to the measurement conditions. This addresses the free-standing portion of #2834; rooftop-specific coefficients are outside this change.
Validation: all 34 tests in
tests/test_temperature.pypass; Flake8 on both changed Python files andgit diff --checkpass. A full documentation build has not been run.AI assistance was used to prepare this patch. The coefficients and measurement guidance were checked against the primary source above, and the implementation was tested locally.