Skip to content

Fixes for oracle - #6

Merged
nikolaushuber merged 13 commits into
mainfrom
fixes-for-oracle
Nov 2, 2026
Merged

nikolaushuber merged 13 commits into
mainfrom
fixes-for-oracle

Conversation

@dorchard

@dorchard dorchard commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Various small fixes of things found by the test oracle.

  • Fix nat_of_integer behaviour on negatives
  • Add async as a keyword
  • Add bracketing for string comparisons (==, <= and ,<`) to avoid issues with chaining.
  • Remove the min and max code printers so that instead the extraction defaults to Isabelle's implementation via if a <= b then a else b (for min) which then generalises better in the Python.

@dorchard

dorchard commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor Author

@nikolaushuber There are now only 2 tests failing but I'm not sure how to solve them....one is about recursion the other is due to a module cycle import!

@nikolaushuber
nikolaushuber marked this pull request as ready for review November 2, 2026 15:05
@nikolaushuber
nikolaushuber changed the base branch from isabelle-python-direct-compare to main November 2, 2026 15:10
@nikolaushuber

Copy link
Copy Markdown
Collaborator

Oracle CI tests are going through now

@nikolaushuber

Copy link
Copy Markdown
Collaborator

Cancelled workflow, as the last commit was purely documentation

@nikolaushuber
nikolaushuber merged commit 8c9a539 into main Nov 2, 2026
0 of 4 checks passed
@nikolaushuber
nikolaushuber deleted the fixes-for-oracle branch November 2, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants