Repository navigation
feat(verify): add KNOWN-GAP bucket waived by approved decision records - #10
Merged
Merged
Conversation
Main has been red since #2 (2026-11-02) on four surface tests for COMP-REQ-KVS-KEY-NAMING and COMP-REQ-KVS-KEY-LENGTH: vendored rust_kvs accepts keys with space, '.', '/' and keys over 32 bytes. That red hid every other regression, including dependabot PRs #8 and #9. verify.py now reports a FAILED comp-req as KNOWN-GAP (exit 0) when an approved decision-record tagged known-gap links satisfies to it. A waived comp-req whose tests all pass is STALE-GAP (exit 1). MISSING is never waivable. DR-KVS-KEY-VALIDATION-GAP waives the two key comp-reqs. Local runs: make verify exit 0: 3 PASSED, 2 KNOWN-GAP verify.py --variant prod exit 1: 1 MISSING (INLINE-STORAGE) verify.py with a waiver on KEY-ENCODING (passing) exit 1: 1 STALE-GAP Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KEjmjapTTSvsFZti3qcD56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main has been red since #2 merged (2026-11-02). Four surface tests fail for COMP-REQ-KVS-KEY-NAMING and COMP-REQ-KVS-KEY-LENGTH because vendored eclipse
rust_kvsaccepts keys containing space,.and/and keys longer than 32 bytes. Dependabot PRs #8 and #9 are red only because they inherit this.Change
tools/verify.py: a FAILED comp-req becomes KNOWN-GAP (exit 0) when an approveddecision-recordtaggedknown-gaplinkssatisfiesto it. If every test on a waived comp-req passes, it becomes STALE-GAP (exit 1) until the waiver is removed. MISSING cannot be waived..verify-output.jsongainsknown_gapandstale_gap.artifacts/safety-and-decisions.yaml:DR-KVS-KEY-VALIDATION-GAPwaives the two key comp-reqs.README.md: the finding section now shows the KNOWN-GAP output and documents the waiver rules.Evidence (local, real bazel)
make verify(dev)verify.py --variant prodverify.pywith a scratch waiver on passing KEY-ENCODINGI have not run
rivet validateon the new decision record locally because the rivet shim is not configured on this machine. CI'smake validateis the first schema check.🤖 Generated with Claude Code
https://claude.ai/code/session_01KEjmjapTTSvsFZti3qcD56