Skip to content

harness setup - #536

Merged
mohitpubnub merged 16 commits into
masterfrom
CLEN-3916-19
Nov 20, 2026
Merged

mohitpubnub merged 16 commits into
masterfrom
CLEN-3916-19

Conversation

@mohitpubnub

Copy link
Copy Markdown
Contributor

docs: repository harness setup files

@pubnub-snyk-universal-prd

pubnub-snyk-universal-prd Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@mohitpubnub mohitpubnub added the priority: medium This PR should be reviewed after all high priority PRs. label Nov 4, 2026

@parfeon parfeon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with few clarification questions)

@@ -0,0 +1,16 @@
#!/bin/bash
# Stop hook. Don't let the agent finish with a failing type check. Keep it under ~30 s.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit confusing statement especially if we skip check when node_modules is missing and we don't force user to run npm ci.

Comment thread AGENTS.md Outdated

## Commands
- Install: `npm install`, as `run-tests.yml` does. Use Node 22 or 24, the CI matrix. Mocha fails at startup on Node 26; that's environmental, not an SDK bug.
- Build (no keys needed): `npm run build:node` (tsc → `lib/` + aggregated `lib/types/index.d.ts`) · `npm run build:web` (rollup → `dist/web/`). Run `build:node` before the `release` or `node` suite.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is actually no need to run build:node before release because release bot does run npm run build before committing change logs. But in case if something has been changed after - then yes.

Comment on lines +7 to +8
| [sdk-specifications](https://github.com/pubnub/sdk-specifications) | `test/specs` | `npm run test:contract:prepare` (rm + shallow clone of `master`) |
| [service-contract-mock](https://github.com/pubnub/service-contract-mock) | `dist/contract` | `npm run contract:refresh` (rm + clone + npm install) |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move these addresses into .env file instead of hardcoding them here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are the public clone URLs already in test:contract:prepare and contract:refresh, not secrets. .env files are gitignored and blocked for agents, so moving them there would hide the setup this skill is meant to document.

@mohitpubnub
mohitpubnub merged commit 5ee5714 into master Nov 20, 2026
28 of 29 checks passed
@mohitpubnub
mohitpubnub deleted the CLEN-3916-19 branch November 20, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: medium This PR should be reviewed after all high priority PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants