Repository navigation
fixed function linking definitions - #415
Merged
Merged
Conversation
JoseAaronLopezGarcia
approved these changes
Nov 14, 2026
JoseAaronLopezGarcia
left a comment
Contributor
There was a problem hiding this comment.
Extremely important, currently can't compile DC10 without this fix.
GrayJack
approved these changes
Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function import is not created doing this as the #ifdef is never actually defined this way.
You can verify that the function is not in the lib with
psp-nm libpsplflash_fatfmt.athe sceLflashFatfmtStartFatfmt funtion is missing.With this patch redoing you can see the lib actually properly shows the
sceLflashFatfmtStartFatfmtfunctionBefore
After:
psp-nm libpsplflash_fatfmt.a LflashFatfmt.o: F_LflashFatfmt_0000.o: U __executable_start 00000000 R __stub_module_LflashFatfmt 00000004 r __stub_modulestr_LflashFatfmt F_LflashFatfmt_0001.o: 00000000 T sceLflashFatfmtStartFatfmt U __stub_module_LflashFatfmt