Repository navigation
Shared pinned-versions check for npm, cargo and python - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
.github/scripts/pinned_versions.pyand reusablepinned-versions.yml. Fails on any dependency that is not one exact version: package.json ranges (peerDependencies exempt), Cargo.toml requirements not written=x.y.z(a bare"1.2"is a range in cargo), and pyproject/requirements entries not==. Also fails on lockfile entries with no integrity hash, like the copiedcheck-pinned-versions.mjsin captcha and captcha-private, which this replaces.Effect
Nothing yet. Once repos call it, an unpinned dependency fails CI. On captcha-private today it finds 46 python and cargo ranges and no npm ones, so those have to be pinned before switching.
Tests
test_pinned_versions.py: 11 unit tests (each range form, cargo workspace/path/git, python markers/URLs, pnpm and npm lockfiles, submodule/ignored-dir skipping, exclude, parse errors).