Repository navigation
Size the node heap from runner RAM in setup-pnpm - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
NODE_OPTIONS=--max-old-space-sizeto 75% of the runner's total RAM (newnode-heap-percentinput). It appends to any existingNODE_OPTIONS, and if the caller already set a heap size, that value wins.node_heap.pyreads RAM on Linux, macOS and Windows. If it can't read RAM it prints a warning and leaves things unchanged, so the step never fails a job.NODE_OPTIONS=4096fromci.yml. A workflow's env doesn't pass into the workflows it calls, and none of its own jobs run node, so the line did nothing.Effect
Tests
test_node_heap.py: 9 tests (sizing, appending, caller value wins, meminfo parsing, unreadable RAM). These run in CI throughrun_python_tests.py.actions-selftest.ymlexercises setup-pnpm on ubuntu and macOS.