Repository navigation
ticker-forex: switch to a keyless endpoint (exchangeratesapi.io now needs a key) - #474
Open
cahthuranag wants to merge 3 commits into
Open
cahthuranag wants to merge 3 commits into
cahthuranag wants to merge 3 commits into
Conversation
api.exchangeratesapi.io now rejects requests without an access key (error 101 missing_access_key), so the script prints nothing. Point it at a keyless endpoint with the same response shape. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
x70b1
approved these changes
Oct 31, 2026
Author
|
@x70b1 thanks for the approval. Anything else needed from me before this is merged? |
Member
|
Oh. Yeah the change is fine. But can you remove the new comments? They add no benefit to 3 lines of shell code. |
Author
Member
|
Please remove also the ad link. |
Author
|
Done, removed the README change. The PR is now just the one-line API URL change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I work on AllRatesToday.
ticker-forex.shcallshttps://api.exchangeratesapi.io/latest, which now returns{"success":false,"error":{"code":101,"type":"missing_access_key"}}for unkeyed requests, so the module shows nothing.This PR points
APIathttps://allratestoday.com/api/compat/exchangeratesapi/latest, which is keyless and returns the same{"base":..,"date":..,"rates":{..}}shape, so thecurl/jqline is unchanged. Rates are ECB reference rates, updated once per working day. Thebaseandsymbolsparameters work as before (any ECB currency as base).The endpoint's terms ask for a visible credit where the rates are shown, so I added a one-line credit to the script's README and a comment in the script. Happy to switch the URL to another keyless source (e.g. Frankfurter) if you prefer that.
Tested:
sh -non the script, and ran it with the default EUR/PLN config; it prints# 4.40. I couldn't run shellcheck locally; CI is the arbiter.