Skip to content

fix(frontend): scroll the search endpoint options inside their card - #448

Merged
polterguy merged 2 commits into
masterfrom
fix/search-endpoint-tab-scroll
Nov 20, 2026
Merged

polterguy merged 2 commits into
masterfrom
fix/search-endpoint-tab-scroll

Conversation

@EbubeEvan

Copy link
Copy Markdown
Collaborator

Summary

On the Search endpoint tab, the bottom of the options card (Rate limit, Generation and the Generate button) was cut off, and nothing could be scrolled to reach it.

The options card sits straight in the page's column, and because it is overflow: hidden, the column squeezed it to the window's height and clipped its last rows. The card is now a column whose rows scroll inside it, with the footer and Generate button always in view below them. The page itself still doesn't scroll, as before.

The same card on the CRUD tab sits inside a container with room to grow, so it looks the same as before.

Also: the Threshold field's placeholder showed as "type's o" because the field is too narrow. It now reads "default", and the tooltip still explains that it uses the type's own threshold.

Test plan

  • npm run lint, npm run format:check, npm run build
  • npm run test (2808 tests)
  • Endpoint Generator → Search endpoint in a short window: the rows scroll inside the card, the footer stays visible, and the page doesn't scroll
  • CRUD backend tab: the options card looks the same as before

🤖 Generated with Claude Code

Checked

  • dotnet build magic.sln passes, which includes the analyzer rules, and dotnet test magic.sln passes
  • cd frontend && npm run build && npm run test passes, if the frontend changed
  • The README of the plugin is updated, if a slot, or the way one is used, changed
  • backend/files/config/appsettings.json is not part of the change

On the Search endpoint tab the options card sits straight in the page's
column, which squeezed it to the window's height and cut off its last
rows. The card is now a column whose rows scroll inside it, with the
footer and its Generate button kept in view below them. The page itself
still doesn't scroll. The threshold placeholder is shortened so it fits
its field.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@EbubeEvan
EbubeEvan requested a review from polterguy as a code owner November 20, 2026 16:51
The footer's flex: none went into a second .crud-opts-footer rule, which
Sonar flags as a duplicate selector (css:S4666). It now sits in the
original rule.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@polterguy
polterguy merged commit 175cd24 into master Nov 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants