Repository navigation
fix(frontend): scroll the search endpoint options inside their card - #448
Merged
Merged
Conversation
On the Search endpoint tab the options card sits straight in the page's column, which squeezed it to the window's height and cut off its last rows. The card is now a column whose rows scroll inside it, with the footer and its Generate button kept in view below them. The page itself still doesn't scroll. The threshold placeholder is shortened so it fits its field. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The footer's flex: none went into a second .crud-opts-footer rule, which Sonar flags as a duplicate selector (css:S4666). It now sits in the original rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
On the Search endpoint tab, the bottom of the options card (Rate limit, Generation and the Generate button) was cut off, and nothing could be scrolled to reach it.
The options card sits straight in the page's column, and because it is
overflow: hidden, the column squeezed it to the window's height and clipped its last rows. The card is now a column whose rows scroll inside it, with the footer and Generate button always in view below them. The page itself still doesn't scroll, as before.The same card on the CRUD tab sits inside a container with room to grow, so it looks the same as before.
Also: the Threshold field's placeholder showed as "type's o" because the field is too narrow. It now reads "default", and the tooltip still explains that it uses the type's own threshold.
Test plan
npm run lint,npm run format:check,npm run buildnpm run test(2808 tests)🤖 Generated with Claude Code
Checked
dotnet build magic.slnpasses, which includes the analyzer rules, anddotnet test magic.slnpassescd frontend && npm run build && npm run testpasses, if the frontend changedbackend/files/config/appsettings.jsonis not part of the change