Skip to content

Read and change weekly schedules #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MartvanMale wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Read and change weekly schedules #943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e79c89e
Add the gateway's weekly schedules to its data
MartvanMale Oct 29, 2026
caaecc3
Add schedule writes
MartvanMale Oct 31, 2026
a0aed0f
Fix switching a schedule on
MartvanMale Oct 31, 2026
ce913dc
Fix schedule writes reaching a rule that is not a schedule
MartvanMale Nov 1, 2026
fbb20e6
Split the schedule slot handling into helpers
MartvanMale Nov 1, 2026
f4ef459
Narrow _in_range to str | float and catch TypeError
MartvanMale Nov 1, 2026
ea65528
Reject an invalid schedule name when looking up its rule
MartvanMale Nov 1, 2026
b332fb6
Create a schedule as active
MartvanMale Nov 10, 2026
c56160c
Describe a created schedule as active in the public API
MartvanMale Nov 10, 2026
a1c8229
Allow a double quote in a schedule name
MartvanMale Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## Ongoing

- Fix switching a schedule on or off sending the schedule's settings to another rule that shares its name, such as a preset rule. A name that belongs only to another rule is now refused. This affected both current and legacy gateways.
- Switching a schedule on also makes it active, so a schedule that was inactive starts running. Switching on a schedule that is already attached no longer adds its zone a second time.
- Add `set_schedule`, `create_schedule` and `delete_schedule` to change, rename, add and remove weekly schedules. A new schedule is active and attached to no zone.
- Add the weekly schedules, with their name, zones and time slots, to the gateway data. The slots are listed in week order, starting on Monday.

## v1.16.0

- Contribution PR [#940](https://github.com/plugwise/python-plugwise/pull/940) by @MartvanMale:
Expand Down
203 changes: 203 additions & 0 deletions fixtures/adam_heatpump_cooling/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,209 @@
"bleeding_hot",
"cooling"
],
"schedules": {
"09314e39f2bd416a889cc6b65b9c0209": {
"active": true,
"name": "Opstaan weekdag",
"slots": [
{
"end": "mo 10:15",
"preset": "home",
"start": "mo 07:00"
},
{
"end": "mo 22:30",
"preset": "away",
"start": "mo 10:15"
},
{
"end": "tu 07:00",
"preset": "asleep",
"start": "mo 22:30"
},
{
"end": "tu 22:30",
"preset": "home",
"start": "tu 07:00"
},
{
"end": "we 07:00",
"preset": "asleep",
"start": "tu 22:30"
},
{
"end": "we 22:30",
"preset": "home",
"start": "we 07:00"
},
{
"end": "th 07:00",
"preset": "asleep",
"start": "we 22:30"
},
{
"end": "th 22:30",
"preset": "home",
"start": "th 07:00"
},
{
"end": "fr 07:00",
"preset": "asleep",
"start": "th 22:30"
},
{
"end": "su 22:30",
"preset": "home",
"start": "fr 07:00"
},
{
"end": "mo 07:00",
"preset": "asleep",
"start": "su 22:30"
}
],
"zones": []
},
"4fed3d61217a408bbee54d56595cd379": {
"active": true,
"name": "Werkdag schema",
"slots": [
{
"end": "mo 17:15",
"preset": "away",
"start": "mo 08:00"
},
{
"end": "mo 23:00",
"preset": "home",
"start": "mo 17:15"
},
{
"end": "tu 08:00",
"preset": "asleep",
"start": "mo 23:00"
},
{
"end": "tu 17:15",
"preset": "away",
"start": "tu 08:00"
},
{
"end": "tu 23:00",
"preset": "home",
"start": "tu 17:15"
},
{
"end": "we 08:00",
"preset": "asleep",
"start": "tu 23:00"
},
{
"end": "we 17:15",
"preset": "away",
"start": "we 08:00"
},
{
"end": "we 23:00",
"preset": "home",
"start": "we 17:15"
},
{
"end": "th 08:00",
"preset": "asleep",
"start": "we 23:00"
},
{
"end": "th 17:15",
"preset": "away",
"start": "th 08:00"
},
{
"end": "th 23:00",
"preset": "home",
"start": "th 17:15"
},
{
"end": "fr 08:00",
"preset": "asleep",
"start": "th 23:00"
},
{
"end": "fr 17:15",
"preset": "away",
"start": "fr 08:00"
},
{
"end": "fr 23:30",
"preset": "home",
"start": "fr 17:15"
},
{
"end": "sa 08:30",
"preset": "asleep",
"start": "fr 23:30"
},
{
"end": "sa 16:30",
"preset": "away",
"start": "sa 08:30"
},
{
"end": "sa 23:30",
"preset": "home",
"start": "sa 16:30"
},
{
"end": "su 09:00",
"setpoint": 17.5,
"start": "sa 23:30"
},
{
"end": "su 23:00",
"preset": "home",
"start": "su 09:00"
},
{
"end": "mo 08:00",
"preset": "asleep",
"start": "su 23:00"
}
],
"zones": [
"fa5fa6b34f6b40a0972988b20e888ed4",
"a562019b0b1f47a4bde8ebe3dbe3e8a9",
"5cc21042f87f4b4c94ccb5537c47a53f",
"8cf650a4c10c44819e426bed406aec34"
]
},
"cad46f09817f4fcf82de44d0a49cf73c": {
"active": true,
"name": "Weekend",
"slots": [
{
"end": "sa 23:00",
"preset": "home",
"start": "sa 08:30"
},
{
"end": "su 08:30",
"preset": "asleep",
"start": "sa 23:00"
},
{
"end": "su 23:00",
"preset": "home",
"start": "su 08:30"
},
{
"end": "sa 08:30",
"preset": "asleep",
"start": "su 23:00"
}
],
"zones": []
}
},
"select_gateway_mode": "full",
"select_regulation_mode": "cooling",
"sensors": {
Expand Down
Loading