Skip to content

Packs: derived Cunning Strike cost and Healing Grace's bound on spend (#251, #252) - #264

Merged
mpigsley merged 2 commits into
mainfrom
packs/derived-params
Nov 2, 2026
Merged

mpigsley merged 2 commits into
mainfrom
packs/derived-params

Conversation

@mpigsley

@mpigsley mpigsley commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Adopts the pack follow-up of #262.

  • 5e-srd-5.2 Cunning Strike (derived parameters, computed values in action-time effects, Effects can't read computed values, and nothing derives a value from an action's parameters #251): the feature's first params effect declares cunningStrikeCost, the Sneak Attack dice the attack's effects spend (the Trip-vs-Huge exception included, guarded on participants.target[0]; one value per attack, so it assumes a single target, as the rules effect did). The rules' sneakAttack effect (value and when) and the two strike action effects (when) read params.cunningStrikeCost, replacing the four copies of the cost expression. The DC is now the feature's computed strikeDc (8 + abilities.dex.mod + proficiency.bonus), read by the strike effects as self.strikeDc; the rogue.strikeDc field, its set effect, display entry and label are removed. Saved shape: unchanged (a derived field, never saved). Interface: field-removed, so a minor bump (new changeset; 5.2 already had a pending minor). Behaviour identical: the three Cunning Strike conformance cases pass unchanged (and a mutated cost fails them).
  • draw-steel-heroes Healing Grace (bounds on an action's existing parameter, A params effect can't bound a parameter the action already declares #252): the max on graceRecoveries becomes a bound on spend (min: graceRecoveries + stand + end), so an overspend is out-of-range on spend with boundBy the ability. Never released, so no upgrade and no new changeset (its first-publish changeset stays).
  • READMEs: 5e-srd-5.2 (computed values note, Cunning Strike notes) and draw-steel-heroes (Healing Grace line) updated.

Skipped: nothing. The follow-up found no other pack restating a parameter-derived value or mirroring a computed value into a field.

Checks: pnpm check, pnpm release (the orc-2e performance test timed out under load once and passes alone; release:check reports 5e-srd-5.2 0.3.0 to 0.4.0 covered), pnpm build:website (0 broken links). Draw Steel ability sweep: 605/605 abilities reached, 0 failures; a direct Healing Grace run gives out-of-range on spend (min 2, 3) for overspends and finishes otherwise.

…mputed value (#251)

Signed-off-by: Mitchel Pigsley <mpigsley@gmail.com>
Signed-off-by: Mitchel Pigsley <mpigsley@gmail.com>
@mpigsley
mpigsley requested a review from a team as a code owner November 2, 2026 17:59
@mpigsley
mpigsley merged commit 4247ddb into main Nov 2, 2026
8 checks passed
@mpigsley
mpigsley deleted the packs/derived-params branch November 2, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant