Repository navigation
Packs: derived Cunning Strike cost and Healing Grace's bound on spend (#251, #252) - #264
Merged
Merged
Conversation
…mputed value (#251) Signed-off-by: Mitchel Pigsley <mpigsley@gmail.com>
Signed-off-by: Mitchel Pigsley <mpigsley@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the pack follow-up of #262.
paramseffect declarescunningStrikeCost, the Sneak Attack dice the attack's effects spend (the Trip-vs-Huge exception included, guarded onparticipants.target[0]; one value per attack, so it assumes a single target, as the rules effect did). The rules'sneakAttackeffect (value andwhen) and the two strikeactioneffects (when) readparams.cunningStrikeCost, replacing the four copies of the cost expression. The DC is now the feature's computedstrikeDc(8 + abilities.dex.mod + proficiency.bonus), read by the strike effects asself.strikeDc; therogue.strikeDcfield, itsseteffect, display entry and label are removed. Saved shape: unchanged (a derived field, never saved). Interface:field-removed, so a minor bump (new changeset; 5.2 already had a pending minor). Behaviour identical: the three Cunning Strike conformance cases pass unchanged (and a mutated cost fails them).maxongraceRecoveriesbecomes a bound onspend(min: graceRecoveries + stand + end), so an overspend isout-of-rangeonspendwithboundBythe ability. Never released, so no upgrade and no new changeset (its first-publish changeset stays).Skipped: nothing. The follow-up found no other pack restating a parameter-derived value or mirroring a computed value into a field.
Checks:
pnpm check,pnpm release(the orc-2e performance test timed out under load once and passes alone;release:checkreports 5e-srd-5.2 0.3.0 to 0.4.0 covered),pnpm build:website(0 broken links). Draw Steel ability sweep: 605/605 abilities reached, 0 failures; a direct Healing Grace run givesout-of-rangeonspend(min 2, 3) for overspends and finishes otherwise.