Repository navigation
Poll reminders: drop the end time, skip the last 30 minutes - #214
Merged
Merged
Conversation
Reminders now just name the poll and link to it (#210). No reminder is posted within 30 minutes of the poll closing, including one running late (#213): it's logged as skipped and recorded, like a reminder over an hour late. Closes #210 Closes #213 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #210
Closes #213
Both come from
/feedbackon how poll reminders feel in practice.What changes
#210: no end time in reminders. A reminder now reads
🗳️ Reminder: vote on **<question>**: <link>. This applies to every poll reminder, not only attendance polls: a native Discord poll already shows its own end time. The poll messages themselves still show when they close (the feedback only named reminders). Still never pings, question still escaped.#213: no reminder in the last 30 minutes before close. In
src/features/schedules/runner.ts:dueRemindertreats a reminder time withinREMINDER_CUTOFF_MS(30 min) ofclosesAtas not due. A reminder at 23:45 for a poll closing at midnight never posts on the last day.remindDuealso skips a reminder due earlier but posted late (it can be up to an hour late) when the actual send time is within that window. It's logged asschedule.reminder_skippedat warn, like the existing "too late" skip, and recorded inlastReminderAtso it isn't tried again.docs/commands.mdsays so too.Not done: a warning on the
/scheduledraft when the reminder time always falls in the window (the issue lists it as optional). The 30 minutes is a constant, not a setting.Tests
dueReminderat 29 / 30 / 45 minutes before close.just checkpasses. No files from rule 14's review list are touched.🤖 Generated with Claude Code