Skip to content

Poll reminders: drop the end time, skip the last 30 minutes - #214

Merged
NinjaLikesCheez merged 1 commit into
mainfrom
fix/poll-reminder-wording-and-cutoff
Nov 12, 2026
Merged

NinjaLikesCheez merged 1 commit into
mainfrom
fix/poll-reminder-wording-and-cutoff

Conversation

@NinjaLikesCheez

Copy link
Copy Markdown
Contributor

Closes #210
Closes #213

Both come from /feedback on how poll reminders feel in practice.

What changes

#210: no end time in reminders. A reminder now reads 🗳️ Reminder: vote on **<question>**: <link>. This applies to every poll reminder, not only attendance polls: a native Discord poll already shows its own end time. The poll messages themselves still show when they close (the feedback only named reminders). Still never pings, question still escaped.

#213: no reminder in the last 30 minutes before close. In src/features/schedules/runner.ts:

  • dueReminder treats a reminder time within REMINDER_CUTOFF_MS (30 min) of closesAt as not due. A reminder at 23:45 for a poll closing at midnight never posts on the last day.
  • remindDue also skips a reminder due earlier but posted late (it can be up to an hour late) when the actual send time is within that window. It's logged as schedule.reminder_skipped at warn, like the existing "too late" skip, and recorded in lastReminderAt so it isn't tried again.
  • The Reminders form hint now says "not in the poll's last 30 minutes", and docs/commands.md says so too.

Not done: a warning on the /schedule draft when the reminder time always falls in the window (the issue lists it as optional). The 30 minutes is a constant, not a setting.

Tests

  • Updated the reminder text expectation.
  • New: dueReminder at 29 / 30 / 45 minutes before close.
  • New: a reminder 40 minutes late that lands within 25 minutes of close is skipped, logged and recorded.

just check passes. No files from rule 14's review list are touched.

🤖 Generated with Claude Code

Reminders now just name the poll and link to it (#210). No reminder is
posted within 30 minutes of the poll closing, including one running late
(#213): it's logged as skipped and recorded, like a reminder over an hour
late.

Closes #210
Closes #213

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@NinjaLikesCheez
NinjaLikesCheez merged commit 6b8e298 into main Nov 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Poll reminders: don't post a reminder within 30 minutes of the poll closing Poll reminders: drop the poll's end time from the reminder message

1 participant