Repository navigation
Conversation
After a column, a functional key part like (IFNULL(c,'x')) was read as a column length and its expression was lost when building the statement, so phpMyAdmin exported a broken index. Each functional key part is now its own entry in Key::$columns. Keys made of expressions only still use Key::$expr. Fixes phpmyadmin#640 Signed-off-by: nik <nik@zendri.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #640
Also fixes phpmyadmin/phpmyadmin#18236
A key mixing columns and functional key parts lost its expressions
when built, e.g.
UNIQUE KEY u (a,(IFNULL(c,'x')))was exported as(a,(x)). Each functional key part is now parsed as its own entry inKey::$columns(with optional ASC/DESC). Keys made of expressionsonly still use
Key::$expr, so existing behaviour stays the same.Disclosure: most of the patch was written by Claude, then reviewed and tested by me.