Repository navigation
Fix GH-14407 mb_http_input tests failed on Windows - #14454
Merged
Merged
Conversation
Originally, the GET method had to be percent encoded. This test did not pass on Windows, so I changed it to a percent-encoded parameter.
mvorisek
reviewed
Jun 3, 2024
Contributor
Author
|
Originally, #14407 is |
Contributor
|
Thanks very much to Hamada-san for investigating this report. I will also
be available to have a look in a few days.
However, if Hamada-san is confident in his fix, he can also go ahead and
merge.
…On Tue, Jun 4, 2024, 9:25 AM tekimen ***@***.***> wrote:
Originally, #14407 <#14407> is $_GET
parameter problem, it's not mb_http_input problem. Hence, Please continue
the review in this state. If $_GET is any wrong, please open other issue.
—
Reply to this email directly, view it on GitHub
<#14454 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIESXYTCKZFUXXWZJOVXCTZFVMWNAVCNFSM6AAAAABIWKN7V6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBWG4YDQMJXGM>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Member
|
@alexdowad can you have a look at this? :) |
Contributor
|
@youkidearitai Hamada-san, I'm sorry for dropping the ball on this one. This is a good change. Do you want to go ahead and merge it? |
Contributor
Author
|
@alexdowad Thanks, merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, the GET method had to be percent encoded. This test did not pass on Windows, so I changed it to a percent-encoded parameter.
closes: #14407