Repository navigation
Release through a pull request now that dev requires Tests - #1506
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devnow accepts only a commit whoseTestscheck has passed, under the ruleset "Default branch: Tests must pass". Admins can override it only by ticking the bypass box when merging a pull request. A direct push of an untested commit is refused for everyone, so the release procedure inCLAUDE.mdcan no longer commit straight todev.The procedure now goes through a pull request:
Versioncommit goes on arelease/<version>branch, and the pull request for it waits forTests.devis then fast-forwarded to that commit, so the tagged commit is the oneTestspassed on.The Conventions section states the rule. This pull request is merged by that same fast-forward, which is the first use of the new step 3.