Repository navigation
fix(tests): resolve temp roots so the suite passes on macOS - #3
Merged
Merged
Conversation
macOS places TMPDIR under /var, a symlink to /private/var. The core lock check and the OpenCode installer correctly refuse symlinked ancestors, so 13 tests failed before reaching their subject. Canonicalize the fixture root; production path checks are unchanged. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On macOS the default temp directory sits below
/var, a symlink to/private/var. The core lock check and the OpenCode installer refuse symlinked ancestors by design, so 13 tests failed before reaching their subject (12 intest_core_sync, 1 intest_method_identity).Change
Canonicalize the fixture root in both tests. Production path checks are unchanged.
Verification
On macOS with the default
TMPDIR:python3 -m unittest discover -s tests -t .runs 165 tests, OK.python3 scripts/validate-pluginpasses.🤖 Generated with Claude Code