Repository navigation
fix(core): compare only the executable bit in the mode drift check - #2
Merged
Merged
Conversation
Git records only the executable bit. On a host with umask 0002 every installed copy is 664/775, so sync-core --check reported mode drift for an intact installation. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sync-core --checkcompared the full permission bits of every managed file with the lock. Git records only the executable bit, so on a host with umask 0002 an intact installation (files 664/775) failed withcore mode drift: CORE_NOTICES.md.The check now compares the owner-executable bit with the locked mode. A lost or added execute bit is still reported. Adds a regression test for 664/775 copies.
Verification:
python3 -m unittest discover -s tests -t .(165 tests, OK) under umask 0002.🤖 Generated with Claude Code