Skip to content

Fix modal geometry & positioning near viewport borders - #3295

Merged
texodus merged 3 commits into
masterfrom
fix-datagrid-query-commands
Nov 20, 2026
Merged

texodus merged 3 commits into
masterfrom
fix-datagrid-query-commands

Conversation

@texodus

@texodus texodus commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

This PR addresses <perspective-viewer> modals geometry and positiong logic, especially with wide, tall, or near-the-viewport-boundary conditions. For example, a <perspective-viewer> with 100 tables near two viewport borders:

Screenshot 2026-11-19 at 3 46 46 PM

This applies to every PortalModal (context menu, command menu, the status bar New/Export/Copy menus and their pickers, the column, filter and function dropdowns) and to context-menu flyouts.

  • The viewport is documentElement.clientWidth/Height, so a classic page scrollbar no longer causes a pixel drift.
  • A wheel outside an open menu now closes it even where nothing scrolls.
  • The function dropdown closes when the expression editor scrolls, and reopens on the next keystroke.
  • The agent chat log scrolling itself as messages arrive closes an open menu.

Also in this branch

  • Fix a bug with restore-order and new setCommandSchema API
  • Add new python-remote-client example, a perspective-python client connected to a perspective-python server in another process over a WebSocket, with a how-to page in the docs.

Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
@texodus texodus added the enhancement Feature requests or improvements label Nov 20, 2026
@texodus texodus changed the title Fix datagrid query commands Fix modal geometry & positioning near viewport borders Nov 20, 2026
Signed-off-by: Andrew Stein <steinlink@gmail.com>
@texodus
texodus force-pushed the fix-datagrid-query-commands branch from b113e88 to fe1dfd6 Compare November 20, 2026 03:16
@texodus
texodus merged commit 366e2ee into master Nov 20, 2026
19 checks passed
@texodus
texodus deleted the fix-datagrid-query-commands branch November 20, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Feature requests or improvements

Development

Successfully merging this pull request may close these issues.

1 participant