Repository navigation
Conversation
…214) * test(filter): pin the space padding rule for raw string values A value that starts or ends with a double quote cannot be matched today, because the opening run of quotes swallows a leading quote and a trailing quote runs into the closing delimiter. These tests pin the padding rule that fixes it: one space is dropped from each end of a raw string value when both ends have a space and the value is not only spaces. They also pin that a raw quoted list for the in operator still drops item quotes. * fix(filter): let a padded raw string match a value with edge quotes A raw string value could not start or end with a double quote. The opening run of quotes took a leading quote as part of the delimiter, and a trailing quote ran into the closing delimiter. Now one space is dropped from each end of a raw string value when both ends have a space and the value is not only spaces, so """ "hi" """ is the value "hi". The scalar string path and the bracket list path also stripped every edge quote from the value after the parser had already removed the delimiters, which undid the padding. The scalar trim is removed. The list trim now applies only to a quoted list for the in operator, which still needs it to unwrap its items. This changes """ x """ from " x " to "x". * docs(readme): remove the em dash from the per-property override note * docs(readme): describe how a list item trims whitespace and keeps edge quotes
Owner
Author
|
Folded into the fix commit on main (1854c5e) instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The README describes how QueryKit works now. The v1.17.1 release notes carry the before and after behavior, so the README does not need the note.
What changed
Verification
git grep 'Before version' README.mdfinds nothing.