Skip to content

fix: show the sidebar section as a middle crumb in the admin top bar - #289

Merged
jaspermayone merged 2 commits into
mainfrom
fix-admin-section-crumb
Nov 12, 2026
Merged

jaspermayone merged 2 commits into
mainfrom
fix-admin-section-crumb

Conversation

@jaspermayone

Copy link
Copy Markdown
Member

Summary

The top bar of the admin and identity layout showed only "Admin / ". A detail page, such as an OAuth app, had no link back to its list.

The top bar now adds the sidebar section of the page as a middle crumb: "Admin / OAuth apps / Quilt Staging". The section link uses the same match that highlights the sidebar, so it works on every admin and identity page.

The middle crumb is left out when it would repeat another crumb:

  • On the section's own list page (a GET of the list URL), where the title already names the section.
  • When the section link goes to the same page as the first crumb (the dashboard, or Verification for a verifier who is not an admin).

A form that fails validation re-renders at the list URL by POST. That page keeps the section crumb.

admin_nav_groups is now built once per request. The sidebar, the command bar and the crumb all read it.

flowchart LR
  A[Active sidebar link] -->|none| X[Admin / Title]
  A -->|same as home crumb| X
  A -->|GET of its own path| X
  A -->|otherwise| Y[Admin / Section / Title]
Loading

Tests

  • spec/requests/admin_nav_spec.rb: three crumbs on an OAuth app page, no extra crumb on the list page, the crumb kept on a failed create, and no repeated crumb for a verifier.
  • bundle exec rspec spec/requests: 1044 examples, 0 failures (before the second commit). admin_nav_spec and view_conventions_spec pass on the final commit.
  • bin/rubocop on the changed Ruby files: no offenses.

Screenshots

The images are on the pr-screenshots branch.

OAuth app detail

The top bar shows "Admin / OAuth apps / Quilt Staging".

Light Dark 390px

OAuth apps list

The top bar shows "Admin / OAuth apps", with no repeated crumb.

Light Dark 390px

Known issue, not from this branch: at 390px the copy button of the client ID on the detail page goes past the card edge.

@jaspermayone
jaspermayone requested a review from a team November 12, 2026 20:35
@jaspermayone
jaspermayone merged commit 1bbf501 into main Nov 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant