Repository navigation
CLI: say whether a slow stop or cancel went through; an ended box is gone - #81
Open
Adambomb210 wants to merge 1 commit into
Open
Adambomb210 wants to merge 1 commit into
Adambomb210 wants to merge 1 commit into
Conversation
…gone Found in the live box test after #80: - `krater stop` timed out ("didn't answer in time") though Krater had done the stop. A change checks the member with Weave first (up to four calls of 10 s each), past the CLI's 30 s timeout when Weave is slow. The CLI now waits 60 s, and when cancel/stop/resume/move still time out it reads the job instead of guessing (never sending it twice): it says the action went through if the job shows it, and otherwise to try again. - `krater show` on a cancelled box still said "Krater saves it every 10 minutes". An ended box now says its disk and saved /workspace are gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two gaps turned up by the live staging box test after #80. Box 5d10ee46 cost $0.01.
krater stoptimed out but had worked. The CLI said staging "didn't answer in time", though the stop was recorded. A change (POST) checks the member with Weave first: token info, userinfo, possibly a service token, and the directory, each with a 10 s timeout. With a slow Weave that runs past the CLI's 30 s limit. Reads skip the directory check, which fitsshowstaying fast. I couldn't confirm this from the server logs, since I have no access to them.httpx.Timeout(60, connect=10)).cancel,stop,resumeormovestill times out, it doesn't send the request again, because Krater may have done it. Instead it reads the job. If the job shows the action (the state it leads to, or its event as the newest), the CLI says it went through and carries on as normal. Otherwise it says to try again and exits 1.krater showon a cancelled box still said "Krater saves it every 10 minutes". An ended box now says its disk and saved/workspaceare gone. The job page already had this right, because an ended box has no machine card.Tests: three new CLI tests cover a slow stop that went through (sent once only), a slow cancel that didn't, and an ended box's
show. The CLI suite passes all 198 tests and ruff is clean. Server code is unchanged.🤖 Generated with Claude Code