Repository navigation
Smoke test polish: krater show marks it, no false upload failure in the log - #79
Merged
Merged
Conversation
…he log - `krater show` says a job is a smoke test, and once it has passed gives the `krater rerun <id> --no-smoke` line (`krater jobs` already marked it). - The runner no longer logs "uploading X failed: context canceled" when the command's end cancels a periodic sync mid-upload. The final push uploads the file again, so it wasn't a failure; a 1-minute smoke test hit it every time, since its timer lands on the 60 s log sync tick. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small gaps the first paid staging smoke test turned up (job c7da2d0d, after #77):
krater showdidn't say a job is a smoke test (krater jobsdid). It now printssmoke test: the command is stopped after N minutes of running, and once the job has passed it adds`krater rerun <id> --no-smoke` queues the full run.flight at that moment logged
uploading attempt-1.log failed: ... context canceled, though the final pushthen saved the whole log. A 1-minute smoke test hit this every time, because its timer lands on the 60 s
log-sync tick.
Syncer.PushandpushWorkspaceno longer log a per-file failure when their context wascancelled. The error is still returned, and
syncLoopalready ignored it.Tests:
go vetandgo test -race ./...pass (newTestACancelledPushDoesNotLogAFailedUpload), and theCLI suite passes 192 tests (new
test_show_says_a_job_is_a_smoke_test). Ruff and gofmt are clean.No migration. The runner change ships with the portal image.
🤖 Generated with Claude Code