Repository navigation
feat(selvage): pass the admin web ui paths through nginx on twill - #100
Merged
Merged
Conversation
9 of 11 tasks
jaspermayone
added a commit
that referenced
this pull request
Nov 13, 2026
* origin/main: feat(krater): blue/green portal deploys, on for staging (#104) feat(krater): pull CI's image instead of building on weft (#103) feat(ansible): run ad converge build from ad.yml (#105) feat(selvage): add a staging instance on twill (#102) feat(selvage): pass the admin web ui paths through nginx on twill (#100)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selvage gets a moderator web UI (patchworklabsorg/selvage#63). nginx on twill passed only
POST /slack/*andGET /up. This PR also passes the web UI paths.= /adminand/admin//auth//assets/= /cableEvery other path is still 404. The app checks the weave role (selvage-moderators or selvage-admins) on every
/adminrequest.The
/cablelocation sets the forwarded headers again, becauseproxyWebsocketsaddsproxy_set_headerin that location and nginx then drops the http-level ones.Checks
nix flake check --no-build --all-systemspasses.nix fmt -- --cireports no changes.hosts/alastor/edge.nixand a loose/adminprefix. The second commit fixes both.Nothing deploys from this PR. It goes out with the single Selvage deploy.