Repository navigation
Conversation
|
Thanks for this, and for the regression test. The concern is right, but we can't merge it as is. On testnet, the relayer reads rpc-1's RPC over the private network ( We addressed it in instead:
Closing in favour of that one. Thanks again for the contribution! |
|
Thanks for the detailed explanation @nol4lej ! Glad the report and regression test helped uncover the --rpc-methods Unsafe issue and inspired the broader RPC_BIND fix in #11. Since the diagnosis directly led to the hardening, would you mind adding a Co-authored-by: Lesnak1 Lesnak1@users.noreply.github.com trailer to the commit, or mentioning the contribution in the release notes? Would love to stay engaged as the testnet runs! |
Summary
--rpc-externalfrom the mainnet and testnet public RPC services so the node RPC stays on loopback and public HTTPS/WSS traffic continues through Caddy.Validation
python -m unittest discover --start-directory tests --verbose— 1 test passed locally.git diff --check— clean.Related to #9 (finding 3).