Repository navigation
Remote corruption - #175
Merged
Merged
Conversation
Both the project source root issue and the incorrect calloc argument order were fixed in upstream libdwarf, the related patches were removed. Ported patch 0002 to 2.3.2, and introduced a new patch to fix another unused variable in libdwarf.
A previous refactor to remove another protocol mode accidentally made ETM return a signal indicating argument parsing failure instead of using the protocol. Fix by not returning early. Experiments show the protocol works perfectly still.
The source loader accidentally ate the character after each newline, rather than the newline itself. This led to consecutive lines disappearing, and lines sometimes losing their first character. The former screwed up the association between lines in the debug info and the file displayed by orbmortem. Fix by zeroing the newline character itself. The character is already consumed according to the `l` and `r` variables; it just needs changing to `\0`.
mubes
force-pushed
the
remote_corruption
branch
from
November 8, 2026 22:35
5479635 to
aac1507
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix slow remote client handling