Repository navigation
Process sub-template applicableEntity when it specializes the parent … - #23
Merged
Merged
Conversation
Ghesselink
approved these changes
Nov 2, 2026
Ghesselink
left a comment
Ghesselink
left a comment
Collaborator
There was a problem hiding this comment.
Tested this on a local ifc4.3-main build: the scope gains IfcExtrudedAreaSolid and IfcRevolvedAreaSolid in both views, looks good ..
Is link [1] correct? It doesn't have an extruded or resolved solid. Di you mean this one? https://standards.buildingsmart.org/IFC/DEV/IFC4_3/HTML/concepts/Product_Shape/Product_Geometric_Representation/Body_Geometry/Body_SweptSolid_Geometry/Body_SweptSolid_PolyCurve_Geometry/content.html
Before:
After:
Before:
After:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…anchor
The template [0] does not have IfcExtrudedAreaSolid and IfcRevolvedAreaSolid in its graph but there is a specialized template [1] that does - also included in the MVDs. What this PR fixes is that the jump from main template to subtemplate constitutes a specialization and this is processed/visited. This only happens here and in the profiles, not seen anywhere else and that's why it went unnoticed.
[0] https://standards.buildingsmart.org/IFC/DEV/IFC4_3/HTML/concepts/Product_Shape/Product_Geometric_Representation/Body_Geometry/Body_SweptSolid_Geometry/content.html
[1] https://standards.buildingsmart.org/IFC/DEV/IFC4_3/HTML/concepts/Product_Shape/Product_Geometric_Representation/Body_Geometry/Body_AdvancedSweptSolid_Geometry/Body_AdvancedSwept_DiskSolid_PolyCurve_Geometry/content.html