Repository navigation
family-story-keeper: never overwrite unread stories, report failed deletes - #394
Open
hassan1731996 wants to merge 3 commits into
Open
hassan1731996 wants to merge 3 commits into
hassan1731996 wants to merge 3 commits into
Conversation
…letes Refuse saves after a failed read, keep both clips of a longer answer, match names strictly, report Drive delete failures, end after two silent questions, and tell new storytellers about shared highlights.
Contributor
🔀 Branch Merge CheckPR direction: ✅ Passed — |
Contributor
✅ Community PR Path Check — PassedAll changed files are inside the |
Contributor
✅ Ability Validation Passed |
Contributor
🔍 Lint ResultsFiles linted: ✅ Flake8 — Passed
|
Ask what name to use when the profile has none, and send at most 40 story summaries to the model.
The platform reads the text data: as a URL scheme in a string literal.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Ability do?
Follow-up to #388 (Family Story Keeper): interviews a family member about their life and replays the stories later, with the storyteller's own voice when Google is linked. This PR covers the reviewer's follow-up items and problems found when re-reading the merged code.
Reviewer items
Found afterwards
Suggested Trigger Words
Unchanged from #388.
Type
External APIs
Testing
Not yet run in the Live Editor. Checked offline: the file compiles, and a small harness covers a failed read versus a missing key (saves refused after a failed read), name matching (ambiguous, partial, "Dad" versus "Dadi") and the update-first save order. Still to run live: record with Google linked and a short answer (two clips), play it back, delete a story and a storyteller, and the silent-question ending. I'll tick the boxes after that.
Checklist
community/my-ability-name/(community/family-story-keeper/)README.mdincluded with description, suggested triggers, and setupAnything else?
Both items first left out are now in this PR: