Skip to content

Add author and descriptions to Türkiye and Ottoman Empire maps - #6493

Open
halil1054 wants to merge 1 commit into
openfrontio:mainfrom
halil1054:map/descriptions
Open

halil1054 wants to merge 1 commit into
openfrontio:mainfrom
halil1054:map/descriptions

Conversation

@halil1054

Copy link
Copy Markdown
Contributor

Description:

Adds the author field and a short description to the Türkiye (#6047) and Ottoman Empire (#6048) maps, as suggested by Tristar on Discord. The descriptions are written to the map_description section of en.json by the map generator.

Small change (10 added lines), no map data changed.

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory (metadata-only change; the existing map tests pass)

Please put your Discord username so you can be contacted if a bug or regression is found:

halil1054

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the PR, @halil1054!

When it's ready for a maintainer to review, comment /ready. That adds the ready-for-review label, which is how we find PRs waiting on us. Until then we assume you're still working on it.

  • Draft PRs can't be marked ready. Click Ready for review on the PR first, then comment /ready.
  • If we request changes, the label comes off. Push your fixes, then comment /ready again so we know to take another look. Pushing alone doesn't put it back in the queue.
  • Comment /unready to take it out of the queue yourself.

See CONTRIBUTING.md for the full process.

@github-actions github-actions Bot added the small-fix Small fix (≤ 50 lines) — auto-applied by PR gate label Nov 20, 2026
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Added author metadata and descriptions for the Ottoman Empire and Türkiye maps. Added matching description keys to the generated map records and English translations.

Changes

Map metadata and descriptions

Layer / File(s) Summary
Add map descriptions
map-generator/assets/maps/{ottomanempire,turkiye}/info.json, packages/engine-api/src/game/Maps.gen.ts, resources/lang/en.json
Added author metadata and description keys for both maps. Added English descriptions of the Ottoman Empire map’s 1683 setting and the Türkiye map’s geography.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

Suggested reviewers: celant

Merge Risk: Minimal · up to 973d1

This change adds author credits and descriptions for the Türkiye and Ottoman Empire maps. No behavior changes and no concrete risk remains. A reviewer still needs to assign a milestone before merging.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: adding an author and descriptions to the Türkiye and Ottoman Empire maps. The diff matches this: it adds author and description metadata to both map info files, the ge…
Description check Passed The description states that the change adds an author field and a short description to the Türkiye and Ottoman Empire maps. It also explains that the descriptions go into the map_description section o…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: adding an author and descriptions to the Türkiye and Ottoman Empire maps. The diff matches this: it adds author and description metadata to both map info files, the generated Maps.gen.ts records, and en.json.

Full details: Description check

Explanation

The description states that the change adds an author field and a short description to the Türkiye and Ottoman Empire maps. It also explains that the descriptions go into the map_description section of en.json. This matches the changeset.

Finishing Touches

Fix failing CI checks

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Two maps gain a name,
Their authors join the record,
Old lands meet new words,
Straits and rivers find their place,
Descriptions now travel with them.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 246a7bc0-fb27-4198-aae4-83c710e1f171
Commits

Reviewing files that changed from the base of the PR and between ad36432 and 973d100.

Files selected for processing: 4

  • map-generator/assets/maps/ottomanempire/info.json
  • map-generator/assets/maps/turkiye/info.json
  • packages/engine-api/src/game/Maps.gen.ts
  • resources/lang/en.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Claude Code Review

Verdict: No issues found. Findings: 0 critical, 0 high, 0 medium, 0 low.

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

What was checked:

  • The author and descriptionKey entries in Maps.gen.ts come in the same order as the generator writes them (map-generator/codegen.go).
  • The map_description.ottomanempire and map_description.turkiye keys match the new en.json entries. Those entries are identical to the info.json descriptions and sit in sorted order (tests/EnJsonSorted.test.ts).
  • resources/lang/en.json is the only translation file changed.
  • Both values satisfy the MapManifest schema (z.string().min(1)).
  • The existing tests in tests/MapConsistency.test.ts already compare these fields across info.json, Maps.gen.ts and en.json.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small-fix Small fix (≤ 50 lines) — auto-applied by PR gate

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant