Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
yocaba
marked this pull request as draft
November 5, 2026 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
REPO_STATUS_CHECKSalso takes{"context": "...", "integration_id": <app ID>}, so a required check only counts when that app reports it, e.g.15368for GitHub Actions.Part of #74
Why
A check required by name alone also accepts a commit status anyone with write access can post through the API. #74 asks for the action pin checks to be required with GitHub Actions as their source, which
repo-settingscouldn't set.Testing
scripts/test-repo-settings.shrunsrepo-settings.shagainst a stubghand checks the ruleset it would send: contexts, objects, a mix, skipped empty strings, and invalid entries failing before any change.Notes for reviewers
repo-settings; before, it was dropped without a word. No consuming repo has such an entry.Checklist