Skip to content

feat: restrict required status checks to an app with integration_id - #91

Draft
yocaba wants to merge 1 commit into
mainfrom
feat/status-check-integration-id
Draft

yocaba wants to merge 1 commit into
mainfrom
feat/status-check-integration-id

Conversation

@yocaba

@yocaba yocaba commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

What

REPO_STATUS_CHECKS also takes {"context": "...", "integration_id": <app ID>}, so a required check only counts when that app reports it, e.g. 15368 for GitHub Actions.

Part of #74

Why

A check required by name alone also accepts a commit status anyone with write access can post through the API. #74 asks for the action pin checks to be required with GitHub Actions as their source, which repo-settings couldn't set.

Testing

scripts/test-repo-settings.sh runs repo-settings.sh against a stub gh and checks the ruleset it would send: contexts, objects, a mix, skipped empty strings, and invalid entries failing before any change.

Notes for reviewers

  • An entry that is neither a non-empty string nor a valid object now fails repo-settings; before, it was dropped without a word. No consuming repo has such an entry.

Checklist

  • Tests added/updated, or confirmed that no tests are required
  • No breaking changes, or upgrade path documented above
  • Readable commit history (squashed and cleaned up as desired)
  • AI code review considered and comments resolved

@coderabbitai

coderabbitai Bot commented Nov 5, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 840723b3-c575-46bd-8541-9821c461d88c
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@yocaba
yocaba marked this pull request as draft November 5, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant