Skip to content

Add support for Django 4.2 through 6 - #157

Open
antidipyramid wants to merge 9 commits into
masterfrom
feature/django6-support
Open

antidipyramid wants to merge 9 commits into
masterfrom
feature/django6-support

Conversation

@antidipyramid

@antidipyramid antidipyramid commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Overview

This PR updates the supported version of Django to >=4.2 and <=6. It also updates the supported Python versions to >=3.10 and <=3.14

I also replaced setup.py with a pyproject.toml file, which is now preferred.

Notes

The biggest changes in this branch are relatively minor:

  • replace index_together with models.Index in models' Meta
  • replace models.NullBooleanField with models.BooleanField(null=True, ...)

Comment thread opencivicdata/core/admin/base.py Resolved
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage is 98.902% — feature/django6-support into master. No base build found for master.

@coveralls

coveralls commented Oct 23, 2026 •

Copy link
Copy Markdown

Coverage Status

Coverage is 98.902% — feature/django6-support into master. No base build found for master.

@hancush hancush left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right! Few things inline.

Comment thread CHANGELOG.md Resolved
Comment thread .github/workflows/package.yml Resolved
Comment thread .github/workflows/package.yml Resolved
Comment thread pyproject.toml Outdated
license = "BSD-3-Clause"
license-files = ["LICENSE"]
requires-python = ">=3.10"
dependencies = ["Django>=4.2", "psycopg2-binary"]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put an upper limit on Django? If we'll support the whole 6 series, let's do <7, otherwise cap it at 6.0. Can you also make sure the changelog is consistent with whatever 6 series support we're adding? Right now, it just says 6.0.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do an upper limit of <7. Django 6.2 is not out till next April but there shouldn't be any breaking changes. Also updated the changelog.

Also included tests for 6.1 in the workflow.

Comment thread README.md Resolved
Comment thread opencivicdata/core/admin/base.py Resolved
@antidipyramid
antidipyramid requested a review from hancush November 6, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants