Skip to content

soc_vweuda: set base url to new portal address - #4348

Merged
LKuemmel merged 4 commits into
openWB:masterfrom
rleidner:soc_vweuda_p10
Nov 17, 2026
Merged

LKuemmel merged 4 commits into
openWB:masterfrom
rleidner:soc_vweuda_p10

Conversation

@rleidner

@rleidner rleidner commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

VW/Cariad changed the BASE URL to the portal.

Summary by Sourcery

Bug Fixes:

  • Update the VW EU Data Act portal base URL to the new VW Group Data Hub address.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="packages/modules/vehicles/vweuda/api.py" line_range="14" />
<code_context>
 from requests import HTTPError, RequestException, Response, Session

-BASE_URL = "https://eu-data-act.drivesomethinggreater.com"
+BASE_URL = "eu-data-act.vwgroup-datahub.com"
 OIDC_AUTHORIZE_URL = "https://identity.vwgroup.io/oidc/v1/authorize"
 CALLBACK_LOGIN_PATH = "/services/callbacklogin"
</code_context>
<issue_to_address>
**Login and vehicle data fail**

When the client builds a portal URL or login redirect from `BASE_URL`, `BASE_URL` lacks a scheme, so `Session.request` raises `MissingSchema` (wrapped as `ApiError`) for portal requests, while the redirect is relative and callback host checks see an empty netloc; login and vehicle-data retrieval fail.

Restore the `https://` scheme in `BASE_URL`.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread packages/modules/vehicles/vweuda/api.py Resolved
@LKuemmel
LKuemmel merged commit 609d649 into openWB:master Nov 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants