Repository navigation
soc_vweuda: set base url to new portal address - #4348
Merged
Merged
Conversation
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="packages/modules/vehicles/vweuda/api.py" line_range="14" />
<code_context>
from requests import HTTPError, RequestException, Response, Session
-BASE_URL = "https://eu-data-act.drivesomethinggreater.com"
+BASE_URL = "eu-data-act.vwgroup-datahub.com"
OIDC_AUTHORIZE_URL = "https://identity.vwgroup.io/oidc/v1/authorize"
CALLBACK_LOGIN_PATH = "/services/callbacklogin"
</code_context>
<issue_to_address>
**Login and vehicle data fail**
When the client builds a portal URL or login redirect from `BASE_URL`, `BASE_URL` lacks a scheme, so `Session.request` raises `MissingSchema` (wrapped as `ApiError`) for portal requests, while the redirect is relative and callback host checks see an empty netloc; login and vehicle-data retrieval fail.
Restore the `https://` scheme in `BASE_URL`.
</issue_to_address>
LKuemmel
requested changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VW/Cariad changed the BASE URL to the portal.
Summary by Sourcery
Bug Fixes: