Skip to content

fix(release): stage Windows desktop resources before installer packaging - #3921

Merged
GCWing merged 1 commit into
mainfrom
gcwing/fix-windows-release-payload
Nov 14, 2026
Merged

GCWing merged 1 commit into
mainfrom
gcwing/fix-windows-release-payload

Conversation

@GCWing

@GCWing GCWing commented Nov 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Stage resources for the custom Windows installer from the generated Tauri resource map before hashing the signed payload. The release build had the frontend, mobile web, worker, extension host, and Flashgrep inputs on disk, but did not stage them beside the signed Desktop executable.
  • Resolve the staging tool from the pinned workflow revision and allow a signed windows-x64 recovery run for an immutable release tag. Keep publication gated on the complete verified artifact set.

Verification

AI-assisted. The failure was reproduced in the Windows job of Desktop Package run 43608131465. The Desktop executable and NSIS bundle were signed, then the custom installer rejected the missing runtime files.

  • pnpm run check:github-config (61 passed, 1 platform-specific skip)
  • pnpm run test:release-packaging (83 passed, 1 platform-specific skip)
  • node --test scripts/linux-binaries-manifest.test.mjs (13 passed)
  • git diff --check and Git object size check

The new fixture exercises Tauri directory and file mapping, nested paths, preservation of the signed executable, and rejection of out-of-tree destinations. A signed Windows build from the existing v1.0.11 tag will validate the full path. This change does not alter product versions or remote protocols. No live remote workspace, remote control, Peer Device Mode, or Detached Dispatch session was exercised.

@GCWing
GCWing merged commit 15ac7c2 into main Nov 14, 2026
15 checks passed
szxufan pushed a commit to szxufan/OpenBitFun that referenced this pull request Nov 15, 2026
Cherry-pick of openBitFun/OpenBitFun@15ac7c21b (PR openBitFun#3921). The installer
payload requires frontend/dist, mobile-web/dist, ext-host/worker_host
resources, and the flashgrep binary, but nothing staged them before
installer:build:only, so the v1.0.10-beta.17 tag build failed at 'Build
and sign custom Windows installer' once the sccache os error 206 no
longer stopped it earlier. The workflow extracts the staging script from
the workflow sha, so older immutable tags get the packaging tooling
without a re-tag. Also picks up the windows-x64 recovery target.

Conflicts resolved for the fork: the upstream repository-transfer docs
section does not apply, and the fork's Linux OCR staging test is kept
alongside the new Windows payload staging test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant