Repository navigation
fix(ci): the dashboard's advisory gate counts what the bundle holds (ADR-0111) - #554
Merged
Merged
Conversation
…ADR-0111) The release of v0.49.0 failed at `npm audit --omit=dev`: an advisory for picomatch (every version, no fix yet) reached the dashboard's runtime tree because vue-router 5 lists picomatch, vite and unplugin as dependencies for its build plugin. None of them has code in the bundle. The build now lists the packages with code in the bundle (`ui/bundle-packages.json`, plus every `workbox-*` package for the service worker and the declared dependencies), and `ui/scripts/audit-shipped.mjs` fails only for an advisory of a package on that list. No list, or no readable answer from npm, fails it. CI (a warning) and the release (required) run the same script. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The release workflow of
v0.49.0failed at the dashboard's advisory gate (npm audit --omit=dev, run 44135547053): GHSA-fc5q-39xc-vjpf for picomatch, every version, no fix yet. picomatch reaches npm's runtime tree only because vue-router 5 lists picomatch, vite and unplugin asdependenciesfor its build plugin; none of them has code in the bundle the hub embeds. npm cannot tell the two apart.ui/vite.config.ts: a build-only plugin writesui/bundle-packages.json, the packages whose modules Rollup puts into the bundle, plus every installedworkbox-*(the service worker is bundled by workbox separately) and the declareddependencies(vueships as@vue/*).ui/scripts/audit-shipped.mjs: fails (exit 1) for an advisory of a package on that list; exit 2 without the list or without readablenpm audit --json; everything else printed as "not shipped".ci.yml(warning) andrelease.yml(required) run it after the build;docs/releasing.mdnames it; ADR-0111.Review card
Approved by the owner in the conversation on 2026-11-17: points 2–4, and point 1 in its second form (1′) after the first form proved not to hold (it was based on
npm lswithoutnode_modulesinstalled).ui/bundle-packages.jsonatnpm run build; the gate refuses an advisory only for a package on that list; no list fails the gate.npm ls --omit=dev; a hand-kept exception listui/scripts/audit-shipped.mjs;docs/releasing.mdnames it.v0.49.0stays unpublished; the same content is released as 0.49.1 (changelog[0.49.1]with a line on 0.49.0);FORWARD_SINCEstays0.49.0.Decided while building: an entry npm marks only "through" another package (vue-router) does not count even when it ships; the package the advisory is for is checked itself.
Verified (Windows)
npm run build: the list holds@vue/*,pinia,vue,vue-router,workbox-*; the gate passes with picomatch and its dependents as "not shipped".picomatchadded to the list by hand → exit 1, "shipped: picomatch * GHSA-fc5q-39xc-vjpf (high)".npm run typecheck,npm test.The release of 0.49.1 follows in its own pull request.
🤖 Generated with Claude Code