Repository navigation
Conversation
…ed boards read Owner requests relayed by Beacon (TaskBoard 2.22.0): - Context menus: a menu on every board card, list row and column header (UiKit menu partial), mirrored by UiKit 2.54's context menu (right-click, Shift+F10, long press). web_ui.context_menus null|true|false. Entries are printed only when allowed (Menu\TaskMenuBuilder, one board decision per page through taskEditDecider()); the writes go through the new task_menu route (POST, CSRF task_board_task_menu, same origin) that checks every right again and reuses TaskManager, TaskMemberAssigner, the eraser and TimeTrack's TimerService. User HTML is stripped of UiKit's context-menu attributes (Text\ReservedAttributeStripper, fail closed). - Focus mode toggle (UiKit 2.55, area tasks) on board, list, calendar and task pages; ui-kit-bundle ^2.55. - Task API lock conflicts answer transaction-doctrine 1.3's shared policy (409 + Retry-After, CONFLICT_001; CONFLICT_002 without Retry-After after a partial commit), was 500; TaskApiConflictResponseFormatter for the responder; transaction-doctrine ^1.3. - Calendar does not widen the page on phones; its toolbar wraps. - TaskApiReadOperations::boardsOfTeam(): spaces, boards with columns and counts in one batch. - composer process-timeout 0 (SF4-I1); HostRoutingControllersTest with every feature on (SF4-I2); PHPUnit memory limit 2G for the HTML report.
CHANGELOG (Unreleased), UPGRADING (To 2.22.0: 503/500 to 409, hosts without NowoTransactionDoctrineBundle, new task_menu route), USAGE (task and column menus, focus mode), CONFIGURATION (web_ui.context_menus), SECURITY, API (CONFLICT_001/002, boardsOfTeam), OpenAPI error codes and the worker audit row.
The demo turns on UiKit's theme.context_menus and theme.focus_mode, its shell is the focus mode root, and requires ui-kit-bundle ^2.55. task-menus.spec.ts: right-click with a submenu write, Shift+F10 on a card and a column header, Tab to the kebab, long press on a phone, the focus toggle on board, list and calendar, and the calendar at phone width.
The board page with 500 cards carried a copy of the three submenus per card and went past 128 MB on PHP 8.4 / 8.5 in ImportControllerMemoryTest (the import's redirect renders the board). They are now one <template id="nowo-task-menu-shared"> per page; task-board.js (task-menu-shared.ts) copies them into a card's or row's hidden slot, with its task id and without its own column and priority, on pointer, key or focus in the capture phase, before UiKit's context menu reads the kebab. Same memory as 2.21.1 for that test; e2e unchanged (Chromium, Firefox, WebKit, phone).
…udit SU)
SU-L1: a Task API lock conflict answered CONFLICT_001 ("send the same
request") after the request had committed part of its work, and a retry
with the same Idempotency-Key could write twice.
- TaskApiCommitWatermark keeps transaction-doctrine's commit-ledger count
in the request attributes when the API controller is chosen (after the
idempotency claim). The ledger is fed by its DBAL middleware, registered
on the connections; transaction-doctrine's own ledger is used when its
commit detection is on. Any later commit makes the conflict CONFLICT_002
without Retry-After, in the API listener and in the responder formatter.
- The idempotency key keeps a CONFLICT_002 answer, so the same key replays
it and writes nothing.
- createTask (task and assignees) and deleteTask run in TaskApiTransaction,
their events dispatched after the commit.
SU-I1: a MySQL lost savepoint (1305) without a deadlock or lock wait
timeout in the chain is CONFLICT_002.
SU-I2: MariaDB 1020 counts as a lock conflict.
SU-I3: UPGRADING notes trusted_proxies for the menu's same-origin check.
SU-I6: column-collapse.ts and task-menu-shared.ts in Vitest coverage.
SU-I8: demo PLAYWRIGHT_IMAGE v1.65.0-jammy.
SECURITY, UPGRADING, API and CHANGELOG wording follows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TaskBoardBundle 2.22.0: context menus, focus mode, lock conflicts 409 + Retry-After
Owner requests relayed by Beacon. One minor release; no schema change. The only behaviour change is the documented status of Task API lock conflicts, which moves from 500/503 to 409.
1. Task and column menus (UiKit 2.54 context menus)
menupartial. Its entries are Open, Edit, Assign (Assign to me / Remove me / Other people…), Status (the board's other columns), Priority, Due date (Today / Tomorrow / In a week / No due date), Tags…, Start timer (only with the TimeTrack integration), Copy link, Duplicate… / Move to… (move.enabled), Archive and Delete.localStorage; nothing is written on the server.web_ui.context_menus:nullfollowstheme.context_menus;trueorfalseforces it on or off.Menu\TaskMenuBuilder):canEditTask(): Edit, Assign, Status, Priority, Due date, Tags, ArchivecanTrackTime()and the time tracker: Start timermove.enabled,canEditTask()andcanEditBoard(): Duplicate, Move tocanManageBoard(): DeletecanManageColumns(): RenamecanEditBoard(): Add tasktaskEditDecider()), not once per card.task_menu:POST /tools/task-board/menu/task, CSRF tokentask_board_task_menu, same origin only (Sec-Fetch-Site, elseOrigin).TaskManager(with the ordered locking from 2.21),TaskMemberAssigner,TaskBoardEraserInterfaceand TimeTrack'sTimerService.nowo-task-menu-form(REQ-TWIG-005).Text\ReservedAttributeStripper, which fails closed as ChatKit 1.33 does. This covers task descriptions, comment bodies and Markdown board descriptions.2. Focus mode (UiKit 2.55)
focus_mode_toggle(areatasks) is on the board, list, calendar and task pages. It renders nothing while the host has focus mode off.nowo-tech/ui-kit-bundle ^2.55.3. 409 + Retry-After (transaction-doctrine ^1.3)
ConflictResponsePolicy: 409 by default, or 503 when the host keeps it.SERVER_001from the bundle, or 503 from the host responder on transaction-doctrine 1.2.LockConflictExceptionInterface,TransientStorageFailure, a DBALRetryableExceptionor PostgreSQL55P03.Retry-Afterwith{err, ECODE: CONFLICT_001}.ConcurrencyConflict::committed), it isCONFLICT_002with noRetry-After.?ConflictResponsePolicyis injected and falls back tonew ConflictResponsePolicy().TaskApiConflictResponseFormatter(ConflictResponseFormatterInterface) is registered only when the interface exists. It finds API requests by their route flag, so Beacon can drop its route-prefix formatter (the codes are the same).NowoTransactionDoctrineBundle.4. Beacon asks
.nowo-task-calis now the positioned ancestor of its screen-reader text and clips sideways overflow._tasks.scssblock can go.TaskApiReadOperations::boardsOfTeam(): spaces, boards with their columns, and counts are read in one batch (2 queries for 1 space × 1 board, and also for 3 spaces × 4 boards).5. Audit follow-ups
config.process-timeout: 0(composer igor).HostRoutingControllersTestalso runs with every feature on (API, sync, calendar, task numbers, move, recurrence, multi-board, templates).Tests
boardsOfTeam()query count.taskEditDecider()equivalence matrix.demo/symfony8/e2e/tests/task-menus.spec.ts), run on the demo in FrankenPHP worker mode:theme.context_menusandtheme.focus_mode, and its shell is the focus mode root.Verification (local, tb222 stacks)
composer test-coverage-100: 2807 tests, 100.00% statements and elements; phpstan clean; cs-fix clean; Igor 759/759 stateless; twig lint and REQ-TWIG-005 OK; translations 7 locales.phpunit.private-em.xml.dist(private EM + XML mapping, the DDD host setup) andTASK_BOARD_TEST_PORTS=twin.uikit-migration.spec.ts› "task page: show scaffold…" (inline subtask treeitem) fails on this demo with the 2.21.1srctoo (checked withsrcstashed); it is unrelated to this PR.